Replace static bufs with a StringInfo in cash_words()
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Tue, 30 Jul 2024 19:02:58 +0000 (22:02 +0300)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Tue, 30 Jul 2024 19:02:58 +0000 (22:02 +0300)
commit5bf948d564e36553d2a1cda3244a52d054238af4
tree15b7743045a02a0f7b83e9f25a5ae73a8e7b3029
parent47c98035c6fbff01724b9a646196c92b99faa6bf
Replace static bufs with a StringInfo in cash_words()

For clarity. The code was correct, and the buffer was large enough,
but string manipulation with no bounds checking is scary.

This incurs an extra palloc+pfree to every call, but in quick
performance testing, it doesn't seem to be significant.

Reviewed-by: Robert Haas
Discussion: https://www.postgresql.org/message-id/7f86e06a-98c5-4ce3-8ec9-3885c8de0358@iki.fi
src/backend/utils/adt/cash.c