More use of getpwuid_r() directly
authorPeter Eisentraut <peter@eisentraut.org>
Mon, 2 Sep 2024 06:16:25 +0000 (08:16 +0200)
committerPeter Eisentraut <peter@eisentraut.org>
Mon, 2 Sep 2024 07:04:30 +0000 (09:04 +0200)
commit4d5111b3f1a151faf8129e38f8424898588e606d
tree6c2e3c4291f4249b25954690b69d6b8c644d6ee6
parent23138284cde438f65f093156e76683d63b826fff
More use of getpwuid_r() directly

Remove src/port/user.c, call getpwuid_r() directly.  This reduces some
complexity and allows better control of the error behavior.  For
example, the old code would in some circumstances silently truncate
the result string, or produce error message strings that the caller
wouldn't use.

src/port/user.c used to be called src/port/thread.c and contained
various portability complications to support thread-safety.  These are
all obsolete, and all but the user-lookup functions have already been
removed.  This patch completes this by also removing the user-lookup
functions.

Also convert src/backend/libpq/auth.c to use getpwuid_r() for
thread-safety.

Originally, I tried to be overly correct by using
sysconf(_SC_GETPW_R_SIZE_MAX) to get the buffer size for getpwuid_r(),
but that doesn't work on FreeBSD.  All the OS where I could find the
source code internally use 1024 as the suggested buffer size, so I
just ended up hardcoding that.  The previous code used BUFSIZ, which
is an unrelated constant from stdio.h, so its use seemed
inappropriate.

Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi>
Discussion: https://www.postgresql.org/message-id/flat/5f293da9-ceb4-4937-8e52-82c25db8e4d3%40eisentraut.org
src/backend/libpq/auth.c
src/bin/psql/nls.mk
src/include/port.h
src/interfaces/libpq/fe-auth.c
src/interfaces/libpq/fe-connect.c
src/interfaces/libpq/nls.mk
src/port/Makefile
src/port/meson.build
src/port/path.c
src/port/user.c [deleted file]