Simplify some ERROR paths clearing wait events and transient files
authorMichael Paquier <michael@paquier.xyz>
Wed, 17 Apr 2019 00:51:45 +0000 (09:51 +0900)
committerMichael Paquier <michael@paquier.xyz>
Wed, 17 Apr 2019 00:51:45 +0000 (09:51 +0900)
commit47ac2033d460cefbbda2e39732e18de521dc6a36
tree6105936878e0017f42fa515674f50dceae7dc57c
parenta6dcf9df4d91ff0db23579f9114079abe6f3e2bf
Simplify some ERROR paths clearing wait events and transient files

Transient files and wait events get normally cleaned up when seeing an
exception (be it in the context of a transaction for a backend or
another process like the checkpointer), hence there is little point in
complicating error code paths to do this work.  This shaves a bit of
code, and removes some extra handling with errno which needed to be
preserved during the cleanup steps done.

Reported-by: Masahiko Sawada
Author: Michael Paquier
Reviewed-by: Tom Lane, Masahiko Sawada
Discussion: https://postgr.es/m/CAD21AoDhHYVq5KkXfkaHhmjA-zJYj-e4teiRAJefvXuKJz1tKQ@mail.gmail.com
src/backend/access/transam/twophase.c
src/backend/replication/logical/origin.c
src/backend/replication/slot.c
src/backend/storage/file/copydir.c