postgres_fdw: Fix bug in connection status check.
authorFujii Masao <fujii@postgresql.org>
Fri, 26 Jul 2024 18:05:47 +0000 (03:05 +0900)
committerFujii Masao <fujii@postgresql.org>
Fri, 26 Jul 2024 18:58:48 +0000 (03:58 +0900)
commit454aab4b738e53a5dbfca9251a7807a2ad21f87e
treeba7557dd1262f048200f85c28cbb24b2d6054fe8
parent4b56bb4ab4856070d5ea4aeafdd663d8bf96b874
postgres_fdw: Fix bug in connection status check.

The buildfarm member "hake" reported a failure in the regression test
added by commit 857df3cef7, where postgres_fdw_get_connections(true)
returned unexpected results.

The function postgres_fdw_get_connections(true) checks
if a connection is closed by using POLLRDHUP in the requested events
and calling poll(). Previously, the function only considered
POLLRDHUP or 0 as valid returned events. However, poll() can also
return POLLHUP, POLLERR, and/or POLLNVAL. So if any of these events
were returned, postgres_fdw_get_connections(true) would report
incorrect results. postgres_fdw_get_connections(true) failed to
account for these return events.

This commit updates postgres_fdw_get_connections(true) to correctly
report a closed connection when poll() returns not only POLLRDHUP
but also POLLHUP, POLLERR, or POLLNVAL.

Discussion: https://postgr.es/m/fd8f6186-9e1e-4b9a-92c5-e71e3697d381@oss.nttdata.com
contrib/postgres_fdw/connection.c