Adjust cost_merge_append() to reflect use of binaryheap_replace_first().
authorTom Lane <tgl@sss.pgh.pa.us>
Sat, 5 Nov 2016 17:48:11 +0000 (13:48 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Sat, 5 Nov 2016 17:48:11 +0000 (13:48 -0400)
commit34ca0905706422c191b3b0afef6e1c5f54399833
tree8f59a4a161001ffba009864365219377e7cddd5c
parent86d19d27ce6d588ebb0afa84f9121515fa11686d
Adjust cost_merge_append() to reflect use of binaryheap_replace_first().

Commit 7a2fe9bd0 improved merge append so that replacement of a tuple
takes log(N) operations, not twice log(N).  Since cost_merge_append knew
about that explicitly, we should adjust it.  This probably makes little
difference in practice, but the obsolete comment is confusing.

Ideally this would have been put in in 9.3 with the underlying behavior
change; but I'm not going to back-patch it, since there's some small chance
of changing a plan choice that somebody's optimized for.

Thomas Munro

Discussion: <CAEepm=0WQBSvuYcMOUj4Ga4NXpu2J=ejZcE=e=eiTjTX-6_gDw@mail.gmail.com>
src/backend/optimizer/path/costsize.c