Fix one-off bug causing missing commit timestamps for subtransactions
authorMichael Paquier <michael@paquier.xyz>
Fri, 21 Jan 2022 05:54:04 +0000 (14:54 +0900)
committerMichael Paquier <michael@paquier.xyz>
Fri, 21 Jan 2022 05:54:04 +0000 (14:54 +0900)
commit237d1f317240b60b3fff698f4e9b184d1db83a6e
treec62c5acb9d7dd340fffde157b45d07404d388686
parentcfe7bd17e4fa987c9ba14add48ea58a41c45ccdb
Fix one-off bug causing missing commit timestamps for subtransactions

The logic in charge of writing commit timestamps (enabled with
track_commit_timestamp) for subtransactions had a one-bug bug,
where it would be possible that commit timestamps go missing for the
last subtransaction committed.

While on it, simplify a bit the iteration logic in the loop writing the
commit timestamps, as per suggestions from Kyotaro Horiguchi and Tom
Lane, so as some variable initializations are not part of the loop
itself.

Issue introduced in 73c986a.

Analyzed-by: Alex Kingsborough
Author: Alex Kingsborough, Kyotaro Horiguchi
Discussion: https://postgr.es/m/73A66172-4050-4F2A-B7F1-13508EDA2144@amazon.com
Backpatch-through: 10
src/backend/access/transam/commit_ts.c