Fix EvalPlanQual rechecking during MERGE.
authorDean Rasheed <dean.a.rasheed@gmail.com>
Sat, 30 Sep 2023 09:52:21 +0000 (10:52 +0100)
committerDean Rasheed <dean.a.rasheed@gmail.com>
Sat, 30 Sep 2023 09:52:21 +0000 (10:52 +0100)
commit1d5caec221d85b8950a1ee3d8bb6fad262549ea6
treedbb0d619c692ab169ee97932ace3cad690950e5f
parentf02154652d1a83d80f4bee93b58ecdbd8c33378b
Fix EvalPlanQual rechecking during MERGE.

Under some circumstances, concurrent MERGE operations could lead to
inconsistent results, that varied according the plan chosen. This was
caused by a lack of rowmarks on the source relation, which meant that
EvalPlanQual rechecking was not guaranteed to return the same source
tuples when re-running the join query.

Fix by ensuring that preprocess_rowmarks() sets up PlanRowMarks for
all non-target relations used in MERGE, in the same way that it does
for UPDATE and DELETE.

Per bug #18103. Back-patch to v15, where MERGE was introduced.

Dean Rasheed, reviewed by Richard Guo.

Discussion: https://postgr.es/m/18103-c4386baab8e355e3%40postgresql.org
src/backend/executor/README
src/backend/executor/nodeModifyTable.c
src/backend/optimizer/plan/planner.c
src/include/nodes/execnodes.h
src/include/nodes/plannodes.h
src/test/isolation/expected/merge-join.out [new file with mode: 0644]
src/test/isolation/isolation_schedule
src/test/isolation/specs/merge-join.spec [new file with mode: 0644]
src/test/regress/expected/merge.out
src/test/regress/expected/with.out