Make ginbuild's funcCtx be independent of its tmpCtx.
authorTom Lane <tgl@sss.pgh.pa.us>
Sun, 29 Mar 2015 18:02:58 +0000 (14:02 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Sun, 29 Mar 2015 18:02:58 +0000 (14:02 -0400)
commit1601830ec20d56dc7bf6b60a34f69841429e4825
tree5cb926ad9e522d7bc554d6d7f0e366c206deeaf4
parent9a8e23311cac14168df6644e03d533a4b07f933e
Make ginbuild's funcCtx be independent of its tmpCtx.

Previously the funcCtx was a child of the tmpCtx, but that was broken
by commit eaa5808e8ec4e82ce1a87103a6b6f687666e4e4c, which made
MemoryContextReset() delete, not reset, child contexts.  The behavior of
having a tmpCtx reset also clear the other context seems rather dubious
anyway, so let's just disentangle them.  Per report from Erik Rijkers.

In passing, fix badly-inaccurate comments about these contexts.
src/backend/access/gin/gininsert.c