Rename lo_create(oid, bytea) to lo_from_bytea().
authorTom Lane <tgl@sss.pgh.pa.us>
Thu, 12 Jun 2014 19:39:09 +0000 (15:39 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Thu, 12 Jun 2014 19:39:09 +0000 (15:39 -0400)
commit154146d208de7518bb6c8131dc8d2361f7f36f56
tree0ac40e6ac000ea4f31bde8ad8d8f781a5e1aaab2
parent7937910781a823382b3f76b4b811791804431927
Rename lo_create(oid, bytea) to lo_from_bytea().

The previous naming broke the query that libpq's lo_initialize() uses
to collect the OIDs of the server-side functions it requires, because
that query effectively assumes that there is only one function named
lo_create in the pg_catalog schema (and likewise only one lo_open, etc).

While we should certainly make libpq more robust about this, the naive
query will remain in use in the field for the foreseeable future, so it
seems the only workable choice is to use a different name for the new
function.  lo_from_bytea() won a small straw poll.

Back-patch into 9.4 where the new function was introduced.
doc/src/sgml/lobj.sgml
src/backend/libpq/be-fsstubs.c
src/include/catalog/catversion.h
src/include/catalog/pg_proc.h
src/include/libpq/be-fsstubs.h
src/test/regress/input/largeobject.source
src/test/regress/output/largeobject.source
src/test/regress/output/largeobject_1.source