Fix incorrect pg_stat_io output on 32-bit machines.
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 6 Sep 2024 15:57:57 +0000 (11:57 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 6 Sep 2024 15:57:57 +0000 (11:57 -0400)
commit129a2f6679fd8891384016b6e2cde6cefda22a7d
tree8f53ddfe290e9e1244dd450ac748a0848a6c85b3
parent9e43ab3dd79ddb5a6a3f7cdb5b1d6dffc9e7765b
Fix incorrect pg_stat_io output on 32-bit machines.

pg_stat_get_io() applied TimestampTzGetDatum twice to the
stat_reset_timestamp value.  On 64-bit builds that's harmless because
TimestampTzGetDatum is a no-op, but on 32-bit builds it results in
displaying garbage in the stats_reset column of the pg_stat_io view.

Bug dates to commit a9c70b46d which introduced pg_stat_io, so
back-patch to v16 where that came in.

Bertrand Drouvot

Discussion: https://postgr.es/m/Ztrd+XcPTz1zorkg@ip-10-97-1-34.eu-west-3.compute.internal
src/backend/utils/adt/pgstatfuncs.c