londiste.drop_obsolete_partitions: changed to raise notice instead of returning rows; defaults to public schema.

1 files changed, 8 insertions, 6 deletions

diff --git a/sql/londiste/functions/londiste.drop_obsolete_partitions.sql b/sql/londiste/functions/londiste.drop_obsolete_partitions.sql
index ff7e0ce8..732d270e 100644
--- a/sql/londiste/functions/londiste.drop_obsolete_partitions.sql
+++ b/sql/londiste/functions/londiste.drop_obsolete_partitions.sql
@@ -5,10 +5,10 @@ create or replace function londiste.drop_obsolete_partitions
   in i_retention_period interval,
   in i_partition_period text
 )
-  returns setof text
+  returns void
 as $$
 -------------------------------------------------------------------------------
---  Function: londiste.drop_obsolete_partitions(2)
+--  Function: londiste.drop_obsolete_partitions(3)
 --
 --    Drop obsolete partitions of partition-by-date parent table.
 --
@@ -16,9 +16,6 @@ as $$
 --    i_parent_table        Master table from which partitions are inherited
 --    i_retention_period    How long to keep partitions around
 --    i_partition_period    One of: year, month, day, hour
---
---  Returns:
---    Names of partitions dropped
 -------------------------------------------------------------------------------
 declare
   _schema text not null := lower (split_part (i_parent_table, '.', 1));
@@ -43,6 +40,11 @@ begin
     raise exception 'not supported i_partition_period: %', i_partition_period;
   end if;
 
+  if length (_table) = 0 then
+    _table := _schema;
+    _schema := 'public';
+  end if;
+
   for _part in
     select quote_ident (t.schemaname) ||'.'|| quote_ident (t.tablename)
       from pg_catalog.pg_tables t
@@ -50,8 +52,8 @@ begin
        and t.tablename ~ ('^'|| _table || _expr ||'$')
        and t.tablename < _table || to_char (now() - i_retention_period, _dfmt)
   loop
+    raise notice 'DROP TABLE %', _part;
     execute 'drop table '|| _part;
-    return next _part;
   end loop;
 end;
 $$ language plpgsql;