python/pgq: relaxed event handling

.tag_done() call is no more required.  Events are by default in
'done' state.

In 2.x events were in 'retry' state by default, which was very bad
idea in retrospect.  Changing them to 'untagged' and still requiring
tag_done() does not seem too good either.  Original reasoning was to
detect and survive errors in scripts, but the result was only
confusion to everybody.

So instead of assuming that script may be buggy, now we assume
that script knows what it does.  And only by explicit action
can they be tagged as retry.

1 files changed, 0 insertions, 1 deletions

diff --git a/scripts/queue_mover.py b/scripts/queue_mover.py
index 6c0556d6..92fe5370 100755
--- a/scripts/queue_mover.py
+++ b/scripts/queue_mover.py
@@ -35,7 +35,6 @@ class QueueMover(pgq.SerialConsumer):
         for ev in ev_list:
             data = [ev.type, ev.data, ev.extra1, ev.extra2, ev.extra3, ev.extra4, ev.time]
             rows.append(data)
-            ev.tag_done()
         fields = ['type', 'data', 'extra1', 'extra2', 'extra3', 'extra4', 'time']
 
         # insert data