summaryrefslogtreecommitdiff
path: root/python/walmgr.py
diff options
context:
space:
mode:
authorSteve Singer2011-03-17 18:18:45 +0000
committerMartin Pihlak2011-03-17 18:19:15 +0000
commitd18347f18b5798dec90eb771c9489a6b28d84e55 (patch)
treed749c428cd952200852b62438db02bd06db79024 /python/walmgr.py
parentd9f94dfa446561286fb2c7d81baf0185101c2f60 (diff)
Move the pg_stop_backup() into a finally: block.
Some instances were reported where the base backup failed with some issue but pg_stop_backup() hadn't been called and had to be called manually. This should make that less likely
Diffstat (limited to 'python/walmgr.py')
-rwxr-xr-xpython/walmgr.py10
1 files changed, 5 insertions, 5 deletions
diff --git a/python/walmgr.py b/python/walmgr.py
index 5b12980d..dfac72e2 100755
--- a/python/walmgr.py
+++ b/python/walmgr.py
@@ -1144,11 +1144,11 @@ config_backup = %(config_backup)s
except Exception, e:
self.log.error(e)
errors = True
-
- try:
- self.pg_stop_backup()
- except:
- pass
+ finally:
+ try:
+ self.pg_stop_backup()
+ except:
+ pass
try:
self.remote_walmgr("xrelease")