diff options
author | Marko Kreen | 2009-06-01 13:32:08 +0000 |
---|---|---|
committer | Marko Kreen | 2009-06-01 13:39:04 +0000 |
commit | be82460b0778e282336e0a73eec5b069cd59bb53 (patch) | |
tree | 59f36e8063218cebff6be4be8ab00b805d1e2c74 /python/pgq/event.py | |
parent | 52fa34d45d19fe4843b77e7ff21a4f9e93832800 (diff) |
python/pgq: relaxed event handling
.tag_done() call is no more required. Events are by default in
'done' state.
In 2.x events were in 'retry' state by default, which was very bad
idea in retrospect. Changing them to 'untagged' and still requiring
tag_done() does not seem too good either. Original reasoning was to
detect and survive errors in scripts, but the result was only
confusion to everybody.
So instead of assuming that script may be buggy, now we assume
that script knows what it does. And only by explicit action
can they be tagged as retry.
Diffstat (limited to 'python/pgq/event.py')
-rw-r--r-- | python/pgq/event.py | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/python/pgq/event.py b/python/pgq/event.py index 93745035..39735507 100644 --- a/python/pgq/event.py +++ b/python/pgq/event.py @@ -19,6 +19,7 @@ _fldmap = { 'ev_extra2': 'ev_extra2', 'ev_extra3': 'ev_extra3', 'ev_extra4': 'ev_extra4', + 'ev_retry': 'ev_retry', 'id': 'ev_id', 'txid': 'ev_txid', @@ -29,6 +30,7 @@ _fldmap = { 'extra2': 'ev_extra2', 'extra3': 'ev_extra3', 'extra4': 'ev_extra4', + 'retry': 'ev_retry', } class Event(object): @@ -42,7 +44,7 @@ class Event(object): def __init__(self, queue_name, row): self._event_row = row - self._status = EV_UNTAGGED + self._status = EV_DONE self.retry_time = 60 self.queue_name = queue_name |