From aed9fa0bd8973fd967724003e641a5b7054d6a80 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Tue, 9 Oct 2018 11:10:07 -0400 Subject: Select appropriate PG_PRINTF_ATTRIBUTE for recent NetBSD. NetBSD-current generates a large number of warnings about "%m" not being appropriate to use with *printf functions. While that's true for their native printf, it's surely not true for snprintf.c, so I think they have misunderstood gcc's definition of the "gnu_printf" archetype. Nonetheless, choosing "__syslog__" instead silences the warnings; so teach configure about that. Since this is only a cosmetic warning issue (and anyway it depends on previous hacking to be self-consistent), no back-patch. Discussion: https://postgr.es/m/16785.1539046036@sss.pgh.pa.us --- src/include/pg_config.h.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src') diff --git a/src/include/pg_config.h.in b/src/include/pg_config.h.in index 7894caa8c12..9798bd24b44 100644 --- a/src/include/pg_config.h.in +++ b/src/include/pg_config.h.in @@ -804,7 +804,7 @@ /* PostgreSQL major version as a string */ #undef PG_MAJORVERSION -/* Define to gnu_printf if compiler supports it, else printf. */ +/* Define to best printf format archetype, usually gnu_printf if available. */ #undef PG_PRINTF_ATTRIBUTE /* PostgreSQL version as a string */ -- cgit v1.2.3