From 110e6dcaa6595cf71be00808e3df0087d1d2b208 Mon Sep 17 00:00:00 2001 From: Fujii Masao Date: Fri, 11 Jul 2025 08:44:32 +0900 Subject: doc: Clarify meaning of "idle" in idle_replication_slot_timeout. This commit updates the documentation to clarify that "idle" in idle_replication_slot_timeout means the replication slot is inactive, that is, not currently used by any replication connection. Without this clarification, "idle" could be misinterpreted to mean that the slot is not advancing or that no data is being streamed, even if a connection exists. Back-patch to v18 where idle_replication_slot_timeout was added. Author: Laurenz Albe Reviewed-by: David G. Johnston Reviewed-by: Gunnar Morling Reviewed-by: Amit Kapila Reviewed-by: Fujii Masao Discussion: https://postgr.es/m/CADGJaX_0+FTguWpNSpgVWYQP_7MhoO0D8=cp4XozSQgaZ40Odw@mail.gmail.com Backpatch-through: 18 --- src/backend/replication/slot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src') diff --git a/src/backend/replication/slot.c b/src/backend/replication/slot.c index c1c0f6c660d..281092279ac 100644 --- a/src/backend/replication/slot.c +++ b/src/backend/replication/slot.c @@ -1892,7 +1892,7 @@ InvalidatePossiblyObsoleteSlot(uint32 possible_causes, * max_slot_wal_keep_size is set to -1 and * idle_replication_slot_timeout is set to 0 during the binary * upgrade. See check_old_cluster_for_valid_slots() where we ensure - * that no invalidated before the upgrade. + * that no slot was invalidated before the upgrade. */ Assert(!(*invalidated && SlotIsLogical(s) && IsBinaryUpgrade)); -- cgit v1.2.3