From 5141e471b36add19fe9d6b461f9ea11c0ca6b373 Mon Sep 17 00:00:00 2001
From: Noah Misch
Date: Sat, 23 Oct 2021 18:36:38 -0700
Subject: Avoid race in RelationBuildDesc() affecting CREATE INDEX
 CONCURRENTLY.

CIC and REINDEX CONCURRENTLY assume backends see their catalog changes
no later than each backend's next transaction start.  That failed to
hold when a backend absorbed a relevant invalidation in the middle of
running RelationBuildDesc() on the CIC index.  Queries that use the
resulting index can silently fail to find rows.  Fix this for future
index builds by making RelationBuildDesc() loop until it finishes
without accepting a relevant invalidation.  It may be necessary to
reindex to recover from past occurrences; REINDEX CONCURRENTLY suffices.
Back-patch to 9.6 (all supported versions).

Noah Misch and Andrey Borodin, reviewed (in earlier versions) by Andres
Freund.

Discussion: https://postgr.es/m/20210730022548.GA1940096@gust.leadboat.com
---
 src/tools/pgindent/typedefs.list | 1 +
 1 file changed, 1 insertion(+)

(limited to 'src/tools/pgindent')

diff --git a/src/tools/pgindent/typedefs.list b/src/tools/pgindent/typedefs.list
index 934e8b36f78..c463596ea7b 100644
--- a/src/tools/pgindent/typedefs.list
+++ b/src/tools/pgindent/typedefs.list
@@ -1002,6 +1002,7 @@ ImportForeignSchemaStmt
 ImportForeignSchemaType
 ImportForeignSchema_function
 ImportQual
+InProgressEnt
 IncludeWal
 InclusionOpaque
 IncrementVarSublevelsUp_context
-- 
cgit v1.2.3