From 9fd45870c1436b477264c0c82eb195df52bc0919 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Sat, 16 Jul 2022 08:42:15 +0200 Subject: Replace many MemSet calls with struct initialization This replaces all MemSet() calls with struct initialization where that is easily and obviously possible. (For example, some cases have to worry about padding bits, so I left those.) (The same could be done with appropriate memset() calls, but this patch is part of an effort to phase out MemSet(), so it doesn't touch memset() calls.) Reviewed-by: Ranier Vilela Reviewed-by: Alvaro Herrera Discussion: https://www.postgresql.org/message-id/9847b13c-b785-f4e2-75c3-12ec77a3b05c@enterprisedb.com --- src/test/modules/test_predtest/test_predtest.c | 3 +-- src/test/regress/regress.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) (limited to 'src/test') diff --git a/src/test/modules/test_predtest/test_predtest.c b/src/test/modules/test_predtest/test_predtest.c index 3b19e0eadc0..2ce88cb6245 100644 --- a/src/test/modules/test_predtest/test_predtest.c +++ b/src/test/modules/test_predtest/test_predtest.c @@ -50,7 +50,7 @@ test_predtest(PG_FUNCTION_ARGS) strong_refuted_by, weak_refuted_by; Datum values[8]; - bool nulls[8]; + bool nulls[8] = {0}; int i; /* We use SPI to parse, plan, and execute the test query */ @@ -204,7 +204,6 @@ test_predtest(PG_FUNCTION_ARGS) "w_r_holds", BOOLOID, -1, 0); tupdesc = BlessTupleDesc(tupdesc); - MemSet(nulls, 0, sizeof(nulls)); values[0] = BoolGetDatum(strong_implied_by); values[1] = BoolGetDatum(weak_implied_by); values[2] = BoolGetDatum(strong_refuted_by); diff --git a/src/test/regress/regress.c b/src/test/regress/regress.c index ba3532a51e8..b88d70b6fcc 100644 --- a/src/test/regress/regress.c +++ b/src/test/regress/regress.c @@ -1110,7 +1110,7 @@ test_enc_conversion(PG_FUNCTION_ARGS) int convertedbytes; int dstlen; Datum values[2]; - bool nulls[2]; + bool nulls[2] = {0}; HeapTuple tuple; if (src_encoding < 0) @@ -1199,7 +1199,6 @@ test_enc_conversion(PG_FUNCTION_ARGS) pfree(dst); } - MemSet(nulls, 0, sizeof(nulls)); values[0] = Int32GetDatum(convertedbytes); values[1] = PointerGetDatum(retval); tuple = heap_form_tuple(tupdesc, values, nulls); -- cgit v1.2.3