From bb54bf22900f76dab6899594d47f55d62e912143 Mon Sep 17 00:00:00 2001 From: Andres Freund Date: Mon, 19 Sep 2022 18:00:50 -0700 Subject: Don't hardcode tmp_check/ as test directory for tap tests This is motivated by the meson patchset, which wants to put the log / data for tests in a different place than the autoconf build. Right now log files for tap tests have to be inside $TESTDIR/tmp_check, whereas log files for pg_regress/isolationtester are outside of tmp_check. This change doesn't fix the latter, but is a prerequisite. The only test that needs adjustment is 010_tab_completion.pl, as it hardcoded the tmp_check/ directory. Instead create a dedicated directory for the test files. It's also a bit cleaner independently, because it doesn't intermingle the test files with more important things like the log/ directory. Reviewed-by: Tom Lane Reviewed-by: Peter Eisentraut Discussion: https://postgr.es/m/1131990.1660661896@sss.pgh.pa.us Discussion: https://postgr.es/m/d861493c-ed20-c251-7a89-7924f5197341@enterprisedb.com --- src/test/perl/PostgreSQL/Test/Utils.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/test/perl') diff --git a/src/test/perl/PostgreSQL/Test/Utils.pm b/src/test/perl/PostgreSQL/Test/Utils.pm index 1ca2cc59170..88a472f2442 100644 --- a/src/test/perl/PostgreSQL/Test/Utils.pm +++ b/src/test/perl/PostgreSQL/Test/Utils.pm @@ -192,7 +192,7 @@ INIT # Determine output directories, and create them. The base path is the # TESTDIR environment variable, which is normally set by the invoking # Makefile. - $tmp_check = $ENV{TESTDIR} ? "$ENV{TESTDIR}/tmp_check" : "tmp_check"; + $tmp_check = $ENV{TESTDIR} ? "$ENV{TESTDIR}" : "tmp_check"; $log_path = "$tmp_check/log"; mkdir $tmp_check; -- cgit v1.2.3