From 2c8118ee5d980e11f73683fcda2329c323aa381e Mon Sep 17 00:00:00 2001 From: Michael Paquier Date: Tue, 12 Mar 2024 10:02:54 +0900 Subject: Use printf's %m format instead of strerror(errno) in more places Most callers of strerror() are removed from the backend code. The remaining callers require special handling with a saved errno from a previous system call. The frontend code still needs strerror() where error states need to be handled outside of fprintf. Note that pg_regress is not changed to use %m as the TAP output may clobber errno, since those functions call fprintf() and friends before evaluating the format string. Support for %m in src/port/snprintf.c has been added in d6c55de1f99a, hence all the stable branches currently supported include it. Author: Dagfinn Ilmari Mannsåker Discussion: https://postgr.es/m/87sf13jhuw.fsf@wibble.ilmari.org --- src/test/isolation/isolationtester.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/test/isolation') diff --git a/src/test/isolation/isolationtester.c b/src/test/isolation/isolationtester.c index 0a66235153a..ed110f740f1 100644 --- a/src/test/isolation/isolationtester.c +++ b/src/test/isolation/isolationtester.c @@ -871,7 +871,7 @@ try_complete_step(TestSpec *testspec, PermutationStep *pstep, int flags) { if (errno == EINTR) continue; - fprintf(stderr, "select failed: %s\n", strerror(errno)); + fprintf(stderr, "select failed: %m\n"); exit(1); } else if (ret == 0) /* select() timeout: check for lock wait */ -- cgit v1.2.3