From 201a76183e2056c2217129e12d68c25ec9c559c8 Mon Sep 17 00:00:00 2001 From: Andrew Dunstan Date: Thu, 29 Jul 2021 05:58:08 -0400 Subject: Unify PostgresNode's new() and get_new_node() methods There is only one constructor now for PostgresNode, with the idiomatic name 'new'. The method is not exported by the class, and must be called as "PostgresNode->new('name',[args])". All the TAP tests that use PostgresNode are modified accordingly. Third party scripts will need adjusting, which is a fairly mechanical process (I just used a sed script). --- src/test/authentication/t/001_password.pl | 2 +- src/test/authentication/t/002_saslprep.pl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'src/test/authentication') diff --git a/src/test/authentication/t/001_password.pl b/src/test/authentication/t/001_password.pl index 427a3601987..9498c18d7d1 100644 --- a/src/test/authentication/t/001_password.pl +++ b/src/test/authentication/t/001_password.pl @@ -62,7 +62,7 @@ sub test_role } # Initialize primary node -my $node = get_new_node('primary'); +my $node = PostgresNode->new('primary'); $node->init; $node->append_conf('postgresql.conf', "log_connections = on\n"); $node->start; diff --git a/src/test/authentication/t/002_saslprep.pl b/src/test/authentication/t/002_saslprep.pl index f080a0ccbae..4799e927dbb 100644 --- a/src/test/authentication/t/002_saslprep.pl +++ b/src/test/authentication/t/002_saslprep.pl @@ -62,7 +62,7 @@ sub test_login # Initialize primary node. Force UTF-8 encoding, so that we can use non-ASCII # characters in the passwords below. -my $node = get_new_node('primary'); +my $node = PostgresNode->new('primary'); $node->init(extra => [ '--locale=C', '--encoding=UTF8' ]); $node->start; -- cgit v1.2.3