From 827b4060a8e35047c1adc9ca2ab3d8e7ad905df0 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Wed, 12 Feb 2025 08:50:13 +0100 Subject: Remove unnecessary (char *) casts [mem] Remove (char *) casts around memory functions such as memcmp(), memcpy(), or memset() where the cast is useless. Since these functions don't take char * arguments anyway, these casts are at best complicated casts to (void *), about which see commit 7f798aca1d5. Reviewed-by: Dagfinn Ilmari Mannsåker Discussion: https://www.postgresql.org/message-id/flat/fd1fcedb-3492-4fc8-9e3e-74b97f2db6c7%40eisentraut.org --- src/interfaces/ecpg/compatlib/informix.c | 2 +- src/interfaces/ecpg/ecpglib/misc.c | 14 +++++++------- 2 files changed, 8 insertions(+), 8 deletions(-) (limited to 'src/interfaces/ecpg') diff --git a/src/interfaces/ecpg/compatlib/informix.c b/src/interfaces/ecpg/compatlib/informix.c index 65a0b2e46c4..e829d722f22 100644 --- a/src/interfaces/ecpg/compatlib/informix.c +++ b/src/interfaces/ecpg/compatlib/informix.c @@ -1035,7 +1035,7 @@ ECPG_informix_reset_sqlca(void) if (sqlca == NULL) return; - memcpy((char *) sqlca, (char *) &sqlca_init, sizeof(struct sqlca_t)); + memcpy(sqlca, &sqlca_init, sizeof(struct sqlca_t)); } int diff --git a/src/interfaces/ecpg/ecpglib/misc.c b/src/interfaces/ecpg/ecpglib/misc.c index 8b38c3eccfd..1885732a652 100644 --- a/src/interfaces/ecpg/ecpglib/misc.c +++ b/src/interfaces/ecpg/ecpglib/misc.c @@ -66,7 +66,7 @@ static FILE *debugstream = NULL; void ecpg_init_sqlca(struct sqlca_t *sqlca) { - memcpy((char *) sqlca, (char *) &sqlca_init, sizeof(struct sqlca_t)); + memcpy(sqlca, &sqlca_init, sizeof(struct sqlca_t)); } bool @@ -316,10 +316,10 @@ ECPGset_noind_null(enum ECPGttype type, void *ptr) *((long long *) ptr) = LONG_LONG_MIN; break; case ECPGt_float: - memset((char *) ptr, 0xff, sizeof(float)); + memset(ptr, 0xff, sizeof(float)); break; case ECPGt_double: - memset((char *) ptr, 0xff, sizeof(double)); + memset(ptr, 0xff, sizeof(double)); break; case ECPGt_varchar: *(((struct ECPGgeneric_varchar *) ptr)->arr) = 0x00; @@ -329,18 +329,18 @@ ECPGset_noind_null(enum ECPGttype type, void *ptr) ((struct ECPGgeneric_bytea *) ptr)->len = 0; break; case ECPGt_decimal: - memset((char *) ptr, 0, sizeof(decimal)); + memset(ptr, 0, sizeof(decimal)); ((decimal *) ptr)->sign = NUMERIC_NULL; break; case ECPGt_numeric: - memset((char *) ptr, 0, sizeof(numeric)); + memset(ptr, 0, sizeof(numeric)); ((numeric *) ptr)->sign = NUMERIC_NULL; break; case ECPGt_interval: - memset((char *) ptr, 0xff, sizeof(interval)); + memset(ptr, 0xff, sizeof(interval)); break; case ECPGt_timestamp: - memset((char *) ptr, 0xff, sizeof(timestamp)); + memset(ptr, 0xff, sizeof(timestamp)); break; default: break; -- cgit v1.2.3