From a475c6036752c26dca538632b68fd2cc592976b7 Mon Sep 17 00:00:00 2001
From: Robert Haas
Date: Thu, 14 Jun 2012 09:58:53 -0400
Subject: Remove misplaced sanity check from heap_create().

Even when allow_system_table_mods is not set, we allow creation of any
type of SQL object in pg_catalog, except for relations.  And you can
get relations into pg_catalog, too, by initially creating them in some
other schema and then moving them with ALTER .. SET SCHEMA.  So this
restriction, which prevents relations (only) from being created in
pg_catalog directly, is fairly pointless.  If we need a safety mechanism
for this, it should be placed further upstream, so that it affects all
SQL objects uniformly, and picks up both CREATE and SET SCHEMA.

For now, just rip it out, per discussion with Tom Lane.
---
 src/include/catalog/heap.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

(limited to 'src/include')

diff --git a/src/include/catalog/heap.h b/src/include/catalog/heap.h
index bc98d5d6fc1..bc8c63a15e1 100644
--- a/src/include/catalog/heap.h
+++ b/src/include/catalog/heap.h
@@ -46,8 +46,7 @@ extern Relation heap_create(const char *relname,
 			char relkind,
 			char relpersistence,
 			bool shared_relation,
-			bool mapped_relation,
-			bool allow_system_table_mods);
+			bool mapped_relation);
 
 extern Oid heap_create_with_catalog(const char *relname,
 						 Oid relnamespace,
-- 
cgit v1.2.3