From 2850896961994aa0993b9e2ed79a209750181b8a Mon Sep 17 00:00:00 2001
From: Tom Lane
Date: Mon, 27 Jan 2014 00:05:49 -0500
Subject: Code review for auto-tuned effective_cache_size.

Fix integer overflow issue noted by Magnus Hagander, as well as a bunch
of other infelicities in commit ee1e5662d8d8330726eaef7d3110cb7add24d058
and its unreasonably large number of followups.
---
 src/include/optimizer/cost.h | 2 --
 src/include/utils/guc.h      | 4 +++-
 2 files changed, 3 insertions(+), 3 deletions(-)

(limited to 'src/include')

diff --git a/src/include/optimizer/cost.h b/src/include/optimizer/cost.h
index e1b7a0b8bc5..ec1605d1c9d 100644
--- a/src/include/optimizer/cost.h
+++ b/src/include/optimizer/cost.h
@@ -27,8 +27,6 @@
 #define DEFAULT_CPU_INDEX_TUPLE_COST 0.005
 #define DEFAULT_CPU_OPERATOR_COST  0.0025
 
-#define DEFAULT_EFFECTIVE_CACHE_SIZE_MULTI 4
-
 typedef enum
 {
 	CONSTRAINT_EXCLUSION_OFF,	/* do not use c_e */
diff --git a/src/include/utils/guc.h b/src/include/utils/guc.h
index 3adcc998600..be68f35d372 100644
--- a/src/include/utils/guc.h
+++ b/src/include/utils/guc.h
@@ -387,8 +387,10 @@ extern void assign_search_path(const char *newval, void *extra);
 
 /* in access/transam/xlog.c */
 extern bool check_wal_buffers(int *newval, void **extra, GucSource source);
+extern void assign_xlog_sync_method(int new_sync_method, void *extra);
+
+/* in optimizer/path/costsize.c */
 extern bool check_effective_cache_size(int *newval, void **extra, GucSource source);
 extern void set_default_effective_cache_size(void);
-extern void assign_xlog_sync_method(int new_sync_method, void *extra);
 
 #endif   /* GUC_H */
-- 
cgit v1.2.3