From 226837e57eb6092b160e7272e7d09a3748c0eb47 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Sun, 13 Apr 2008 20:51:21 +0000 Subject: Since createplan.c no longer cares whether index operators are lossy, it has no particular need to do get_op_opfamily_properties() while building an indexscan plan. Postpone that lookup until executor start. This simplifies createplan.c a lot more than it complicates nodeIndexscan.c, and makes things more uniform since we already had to do it that way for RowCompare expressions. Should be a bit faster too, at least for plans that aren't re-used many times, since we avoid palloc'ing and perhaps copying the intermediate list data structure. --- src/include/nodes/plannodes.h | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) (limited to 'src/include/nodes') diff --git a/src/include/nodes/plannodes.h b/src/include/nodes/plannodes.h index e0deee3afc0..6fb93e810da 100644 --- a/src/include/nodes/plannodes.h +++ b/src/include/nodes/plannodes.h @@ -7,7 +7,7 @@ * Portions Copyright (c) 1996-2008, PostgreSQL Global Development Group * Portions Copyright (c) 1994, Regents of the University of California * - * $PostgreSQL: pgsql/src/include/nodes/plannodes.h,v 1.99 2008/01/01 19:45:58 momjian Exp $ + * $PostgreSQL: pgsql/src/include/nodes/plannodes.h,v 1.100 2008/04/13 20:51:21 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -241,10 +241,6 @@ typedef Scan SeqScan; * table). This is a bit hokey ... would be cleaner to use a special-purpose * node type that could not be mistaken for a regular Var. But it will do * for now. - * - * indexstrategy and indexsubtype are lists corresponding one-to-one with - * indexqual; they give information about the indexable operators that appear - * at the top of each indexqual. * ---------------- */ typedef struct IndexScan @@ -253,8 +249,6 @@ typedef struct IndexScan Oid indexid; /* OID of index to scan */ List *indexqual; /* list of index quals (OpExprs) */ List *indexqualorig; /* the same in original form */ - List *indexstrategy; /* integer list of strategy numbers */ - List *indexsubtype; /* OID list of strategy subtypes */ ScanDirection indexorderdir; /* forward or backward or don't care */ } IndexScan; @@ -281,8 +275,6 @@ typedef struct BitmapIndexScan Oid indexid; /* OID of index to scan */ List *indexqual; /* list of index quals (OpExprs) */ List *indexqualorig; /* the same in original form */ - List *indexstrategy; /* integer list of strategy numbers */ - List *indexsubtype; /* OID list of strategy subtypes */ } BitmapIndexScan; /* ---------------- -- cgit v1.2.3