From e890ce7a4feb9d72cd502d52c5a4c4d853801974 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Fri, 26 Aug 2022 19:16:28 +0200 Subject: Remove unneeded null pointer checks before PQfreemem() PQfreemem() just calls free(), and the latter already checks for null pointers. Reviewed-by: Tom Lane Discussion: https://www.postgresql.org/message-id/flat/cf26e970-8e92-59f1-247a-aa265235075b%40enterprisedb.com --- src/backend/replication/libpqwalreceiver/libpqwalreceiver.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'src/backend/replication') diff --git a/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c b/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c index 28650245245..7f697b0f292 100644 --- a/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c +++ b/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c @@ -741,8 +741,7 @@ static void libpqrcv_disconnect(WalReceiverConn *conn) { PQfinish(conn->streamConn); - if (conn->recvBuf != NULL) - PQfreemem(conn->recvBuf); + PQfreemem(conn->recvBuf); pfree(conn); } @@ -768,8 +767,7 @@ libpqrcv_receive(WalReceiverConn *conn, char **buffer, { int rawlen; - if (conn->recvBuf != NULL) - PQfreemem(conn->recvBuf); + PQfreemem(conn->recvBuf); conn->recvBuf = NULL; /* Try to receive a CopyData message */ -- cgit v1.2.3