From cbbe75fe67195d9ee3efb2ea7af216c37a521cbf Mon Sep 17 00:00:00 2001
From: Tom Lane
Date: Fri, 13 Jul 2018 18:45:30 -0400
Subject: Fix crash in contrib/ltree's lca() function for empty input array.
lca_inner() wasn't prepared for the possibility of getting no inputs.
Fix that, and make some cosmetic improvements to the code while at it.
Also, I thought the documentation of this function as returning the
"longest common prefix" of the paths was entirely misleading; it really
returns a path one shorter than the longest common prefix, for the typical
definition of "prefix". Don't use that term in the docs, and adjust the
examples to clarify what really happens.
This has been broken since its beginning, so back-patch to all supported
branches.
Per report from Hailong Li. Thanks to Pierre Ducroquet for diagnosing
and for the initial patch, though I whacked it around some and added
test cases.
Discussion: https://postgr.es/m/5b0d8e4f-f2a3-1305-d612-e00e35a7be66@qunar.com
---
doc/src/sgml/ltree.sgml | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
(limited to 'doc/src')
diff --git a/doc/src/sgml/ltree.sgml b/doc/src/sgml/ltree.sgml
index 9855d2c9c89..6f284257f51 100644
--- a/doc/src/sgml/ltree.sgml
+++ b/doc/src/sgml/ltree.sgml
@@ -457,17 +457,17 @@ Europe & Russia*@ & !Transportation
lca(ltree, ltree, ...)lca
ltree
- lowest common ancestor, i.e., longest common prefix of paths
+ longest common ancestor of paths
(up to 8 arguments supported)
- lca('1.2.2.3','1.2.3.4.5.6')
+ lca('1.2.3','1.2.3.4.5.6')
1.2
lca(ltree[])
ltree
- lowest common ancestor, i.e., longest common prefix of paths
- lca(array['1.2.2.3'::ltree,'1.2.3'])
+ longest common ancestor of paths in array
+ lca(array['1.2.3'::ltree,'1.2.3.4'])
1.2
--
cgit v1.2.3