From 8fba928fd78856712f69d96852f8061e77390fda Mon Sep 17 00:00:00 2001 From: Thomas Munro Date: Thu, 23 Mar 2023 12:39:43 +1300 Subject: Improve the naming of Parallel Hash Join phases. * Commit 3048898e dropped -ING from PHJ wait event names. Update the corresponding barrier phases names to match. * Rename the "DONE" phases to "FREE". That's symmetrical with "ALLOCATE", and names the activity that actually happens in that phase (as we do for the other phases) rather than a state. The bug fixed by commit 8d578b9b might have been more obvious with this name. * Rename the batch/bucket growth barriers' "ALLOCATE" phases to "REALLOCATE", a better description of what they do. * Update the high level comments about phases to highlight phases are executed by a single process with an asterisk (mostly memory management phases). No behavior change, as this is just improving internal identifiers. The only user-visible sign of this is that a couple of wait events' display names change from "...Allocate" to "...Reallocate" in pg_stat_activity, to stay in sync with the internal names. Reviewed-by: Melanie Plageman Discussion: https://postgr.es/m/CA%2BhUKG%2BMDpwF2Eo2LAvzd%3DpOh81wUTsrwU1uAwR-v6OGBB6%2B7g%40mail.gmail.com --- doc/src/sgml/monitoring.sgml | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) (limited to 'doc/src') diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml index 2ae24127a83..7ab4424bf13 100644 --- a/doc/src/sgml/monitoring.sgml +++ b/doc/src/sgml/monitoring.sgml @@ -1700,11 +1700,6 @@ postgres 27093 0.0 0.0 30096 2752 ? Ss 11:34 0:00 postgres: ser Waiting for other Parallel Hash participants to finish partitioning the outer relation. - - HashGrowBatchesAllocate - Waiting for an elected Parallel Hash participant to allocate more - batches. - HashGrowBatchesDecide Waiting to elect a Parallel Hash participant to decide on future @@ -1720,21 +1715,26 @@ postgres 27093 0.0 0.0 30096 2752 ? Ss 11:34 0:00 postgres: ser Waiting for an elected Parallel Hash participant to decide on future batch growth. + + HashGrowBatchesReallocate + Waiting for an elected Parallel Hash participant to allocate more + batches. + HashGrowBatchesRepartition Waiting for other Parallel Hash participants to finish repartitioning. - - HashGrowBucketsAllocate - Waiting for an elected Parallel Hash participant to finish - allocating more buckets. - HashGrowBucketsElect Waiting to elect a Parallel Hash participant to allocate more buckets. + + HashGrowBucketsReallocate + Waiting for an elected Parallel Hash participant to finish + allocating more buckets. + HashGrowBucketsReinsert Waiting for other Parallel Hash participants to finish inserting -- cgit v1.2.3