From aa6954104644334c53838f181053b9f7aa13f58c Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Tue, 7 Feb 2023 06:53:05 +0100 Subject: Remove useless casts to (void *) in arguments of some system functions The affected functions are: bsearch, memcmp, memcpy, memset, memmove, qsort, repalloc Reviewed-by: Corey Huinker Discussion: https://www.postgresql.org/message-id/flat/fd9adf5d-b1aa-e82f-e4c7-263c30145807%40enterprisedb.com --- contrib/pg_trgm/trgm_gist.c | 10 +++++----- contrib/pg_trgm/trgm_op.c | 4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) (limited to 'contrib/pg_trgm') diff --git a/contrib/pg_trgm/trgm_gist.c b/contrib/pg_trgm/trgm_gist.c index ef5d8cca784..9ef2e38560a 100644 --- a/contrib/pg_trgm/trgm_gist.c +++ b/contrib/pg_trgm/trgm_gist.c @@ -102,7 +102,7 @@ makesign(BITVECP sign, TRGM *a, int siglen) trgm *ptr = GETARR(a); int32 tmp = 0; - MemSet((void *) sign, 0, siglen); + MemSet(sign, 0, siglen); SETBIT(sign, SIGLENBIT(siglen)); /* set last unused bit */ for (k = 0; k < len; k++) { @@ -755,7 +755,7 @@ fillcache(CACHESIGN *item, TRGM *key, BITVECP sign, int siglen) else if (ISALLTRUE(key)) item->allistrue = true; else - memcpy((void *) item->sign, (void *) GETSIGN(key), siglen); + memcpy(item->sign, GETSIGN(key), siglen); } #define WISH_F(a,b,c) (double)( -(double)(((a)-(b))*((a)-(b))*((a)-(b)))*(c) ) @@ -872,7 +872,7 @@ gtrgm_picksplit(PG_FUNCTION_ARGS) size_beta = hemdistcache(&(cache[seed_2]), &(cache[j]), siglen); costvector[j - 1].cost = abs(size_alpha - size_beta); } - qsort((void *) costvector, maxoff, sizeof(SPLITCOST), comparecost); + qsort(costvector, maxoff, sizeof(SPLITCOST), comparecost); for (k = 0; k < maxoff; k++) { @@ -921,7 +921,7 @@ gtrgm_picksplit(PG_FUNCTION_ARGS) if (ISALLTRUE(datum_l) || cache[j].allistrue) { if (!ISALLTRUE(datum_l)) - memset((void *) GETSIGN(datum_l), 0xff, siglen); + memset(GETSIGN(datum_l), 0xff, siglen); } else { @@ -937,7 +937,7 @@ gtrgm_picksplit(PG_FUNCTION_ARGS) if (ISALLTRUE(datum_r) || cache[j].allistrue) { if (!ISALLTRUE(datum_r)) - memset((void *) GETSIGN(datum_r), 0xff, siglen); + memset(GETSIGN(datum_r), 0xff, siglen); } else { diff --git a/contrib/pg_trgm/trgm_op.c b/contrib/pg_trgm/trgm_op.c index 2c644bc1485..49d4497b4f3 100644 --- a/contrib/pg_trgm/trgm_op.c +++ b/contrib/pg_trgm/trgm_op.c @@ -376,7 +376,7 @@ generate_trgm(char *str, int slen) */ if (len > 1) { - qsort((void *) GETARR(trg), len, sizeof(trgm), comp_trgm); + qsort(GETARR(trg), len, sizeof(trgm), comp_trgm); len = qunique(GETARR(trg), len, sizeof(trgm), comp_trgm); } @@ -929,7 +929,7 @@ generate_wildcard_trgm(const char *str, int slen) */ if (len > 1) { - qsort((void *) GETARR(trg), len, sizeof(trgm), comp_trgm); + qsort(GETARR(trg), len, sizeof(trgm), comp_trgm); len = qunique(GETARR(trg), len, sizeof(trgm), comp_trgm); } -- cgit v1.2.3