From d746021de18baf0f29eff0388204a0664f41eb8b Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Fri, 1 Jul 2022 10:51:45 +0200 Subject: Add construct_array_builtin, deconstruct_array_builtin There were many calls to construct_array() and deconstruct_array() for built-in types, for example, when dealing with system catalog columns. These all hardcoded the type attributes necessary to pass to these functions. To simplify this a bit, add construct_array_builtin(), deconstruct_array_builtin() as wrappers that centralize this hardcoded knowledge. This simplifies many call sites and reduces the amount of hardcoded stuff that is spread around. Reviewed-by: Tom Lane Discussion: https://www.postgresql.org/message-id/flat/2914356f-9e5f-8c59-2995-5997fc48bcba%40enterprisedb.com --- contrib/pageinspect/hashfuncs.c | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) (limited to 'contrib/pageinspect/hashfuncs.c') diff --git a/contrib/pageinspect/hashfuncs.c b/contrib/pageinspect/hashfuncs.c index 69af7b962ff..5287dbe1a30 100644 --- a/contrib/pageinspect/hashfuncs.c +++ b/contrib/pageinspect/hashfuncs.c @@ -564,21 +564,11 @@ hash_metapage_info(PG_FUNCTION_ARGS) for (i = 0; i < HASH_MAX_SPLITPOINTS; i++) spares[i] = Int64GetDatum((int64) metad->hashm_spares[i]); - values[j++] = PointerGetDatum(construct_array(spares, - HASH_MAX_SPLITPOINTS, - INT8OID, - sizeof(int64), - FLOAT8PASSBYVAL, - TYPALIGN_DOUBLE)); + values[j++] = PointerGetDatum(construct_array_builtin(spares, HASH_MAX_SPLITPOINTS, INT8OID)); for (i = 0; i < HASH_MAX_BITMAPS; i++) mapp[i] = Int64GetDatum((int64) metad->hashm_mapp[i]); - values[j++] = PointerGetDatum(construct_array(mapp, - HASH_MAX_BITMAPS, - INT8OID, - sizeof(int64), - FLOAT8PASSBYVAL, - TYPALIGN_DOUBLE)); + values[j++] = PointerGetDatum(construct_array_builtin(mapp, HASH_MAX_BITMAPS, INT8OID)); tuple = heap_form_tuple(tupleDesc, values, nulls); -- cgit v1.2.3