From d746021de18baf0f29eff0388204a0664f41eb8b Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Fri, 1 Jul 2022 10:51:45 +0200 Subject: Add construct_array_builtin, deconstruct_array_builtin There were many calls to construct_array() and deconstruct_array() for built-in types, for example, when dealing with system catalog columns. These all hardcoded the type attributes necessary to pass to these functions. To simplify this a bit, add construct_array_builtin(), deconstruct_array_builtin() as wrappers that centralize this hardcoded knowledge. This simplifies many call sites and reduces the amount of hardcoded stuff that is spread around. Reviewed-by: Tom Lane Discussion: https://www.postgresql.org/message-id/flat/2914356f-9e5f-8c59-2995-5997fc48bcba%40enterprisedb.com --- contrib/pageinspect/btreefuncs.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) (limited to 'contrib/pageinspect/btreefuncs.c') diff --git a/contrib/pageinspect/btreefuncs.c b/contrib/pageinspect/btreefuncs.c index 62f2c1b3159..9375d55e149 100644 --- a/contrib/pageinspect/btreefuncs.c +++ b/contrib/pageinspect/btreefuncs.c @@ -425,11 +425,7 @@ bt_page_print_tuples(struct user_args *uargs) tids_datum = (Datum *) palloc(nposting * sizeof(Datum)); for (int i = 0; i < nposting; i++) tids_datum[i] = ItemPointerGetDatum(&tids[i]); - values[j++] = PointerGetDatum(construct_array(tids_datum, - nposting, - TIDOID, - sizeof(ItemPointerData), - false, TYPALIGN_SHORT)); + values[j++] = PointerGetDatum(construct_array_builtin(tids_datum, nposting, TIDOID)); pfree(tids_datum); } else -- cgit v1.2.3