From 549ec201d6132b7c7ee11ee90a4e02119259ba5b Mon Sep 17 00:00:00 2001 From: Daniel Gustafsson Date: Fri, 11 Feb 2022 20:54:44 +0100 Subject: Replace Test::More plans with done_testing Rather than doing manual book keeping to plan the number of tests to run in each TAP suite, conclude each run with done_testing() summing up the the number of tests that ran. This removes the need for maintaning and updating the plan count at the expense of an accurate count of remaining during the test suite runtime. This patch has been discussed a number of times, often in the context of other patches which updates tests, so a larger number of discussions can be found in the archives. Reviewed-by: Julien Rouhaud Reviewed-by: Dagfinn Ilmari Mannsåker Reviewed-by: Tom Lane Reviewed-by: Michael Paquier Reviewed-by: Kyotaro Horiguchi Discussion: https://postgr.es/m/DD399313-3D56-4666-8079-88949DAC870F@yesql.se --- contrib/amcheck/t/001_verify_heapam.pl | 4 +++- contrib/amcheck/t/002_cic.pl | 2 +- contrib/amcheck/t/003_cic_2pc.pl | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) (limited to 'contrib/amcheck') diff --git a/contrib/amcheck/t/001_verify_heapam.pl b/contrib/amcheck/t/001_verify_heapam.pl index 39c11634b85..bb0997cd5d9 100644 --- a/contrib/amcheck/t/001_verify_heapam.pl +++ b/contrib/amcheck/t/001_verify_heapam.pl @@ -8,7 +8,7 @@ use PostgreSQL::Test::Cluster; use PostgreSQL::Test::Utils; use Fcntl qw(:seek); -use Test::More tests => 272; +use Test::More; my ($node, $result); @@ -283,3 +283,5 @@ sub check_all_options_uncorrupted } } } + +done_testing(); diff --git a/contrib/amcheck/t/002_cic.pl b/contrib/amcheck/t/002_cic.pl index f6b91e89ad3..d604def0d02 100644 --- a/contrib/amcheck/t/002_cic.pl +++ b/contrib/amcheck/t/002_cic.pl @@ -9,7 +9,7 @@ use Config; use PostgreSQL::Test::Cluster; use PostgreSQL::Test::Utils; -use Test::More tests => 3; +use Test::More; my ($node, $result); diff --git a/contrib/amcheck/t/003_cic_2pc.pl b/contrib/amcheck/t/003_cic_2pc.pl index 44b425f5587..f668ed3c40a 100644 --- a/contrib/amcheck/t/003_cic_2pc.pl +++ b/contrib/amcheck/t/003_cic_2pc.pl @@ -9,7 +9,7 @@ use Config; use PostgreSQL::Test::Cluster; use PostgreSQL::Test::Utils; -use Test::More tests => 5; +use Test::More; Test::More->builder->todo_start('filesystem bug') if PostgreSQL::Test::Utils::has_wal_read_bug; -- cgit v1.2.3