From 558730ac6bbc668a75c7a7619beae5a1b34d965f Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Tue, 2 Aug 2005 19:02:32 +0000 Subject: Clean up CREATE DATABASE processing to make it more robust and get rid of special case for Windows port. Put a PG_TRY around most of createdb() to ensure that we remove copied subdirectories on failure, even if the failure happens while creating the pg_database row. (I think this explains Oliver Siegmar's recent report.) Having done that, there's no need for the fragile assumption that copydir() mustn't ereport(ERROR), so simplify its API. Eliminate the old code that used system("cp ...") to copy subdirectories, in favor of using copydir() on all platforms. This not only should allow much better error reporting, but allows us to fsync the created files before trusting that the copy has succeeded. --- configure | 8 -------- 1 file changed, 8 deletions(-) (limited to 'configure') diff --git a/configure b/configure index 84ce2bcc834..1f2f679c642 100755 --- a/configure +++ b/configure @@ -14915,14 +14915,6 @@ fi # Win32 support if test "$PORTNAME" = "win32"; then -case $LIBOBJS in - "copydir.$ac_objext" | \ - *" copydir.$ac_objext" | \ - "copydir.$ac_objext "* | \ - *" copydir.$ac_objext "* ) ;; - *) LIBOBJS="$LIBOBJS copydir.$ac_objext" ;; -esac - case $LIBOBJS in "gettimeofday.$ac_objext" | \ *" gettimeofday.$ac_objext" | \ -- cgit v1.2.3