diff options
| author | Alvaro Herrera | 2022-03-23 18:23:51 +0000 |
|---|---|---|
| committer | Alvaro Herrera | 2022-03-23 18:23:51 +0000 |
| commit | efe44fb2f685032ab73ec99cd39712a1ad458c3c (patch) | |
| tree | 3b9e1954f87857501d5ea6a2ce5f4c3286a3c318 /src | |
| parent | 199cd7b59a16cb5b5de54ad7d9c1eea129e03833 (diff) | |
pg_upgrade: Upgrade an Assert to a real 'if' test
It seems possible for the condition being tested to be true in
production, and nobody would never know (except when some data
eventually becomes corrupt?).
Author: Álvaro Herrera <alvherre@alvh.no-ip.org>
Discussion: https://postgr.es/m//202109040001.zky3wgv2qeqg@alvherre.pgsql
Diffstat (limited to 'src')
| -rw-r--r-- | src/bin/pg_rewind/parsexlog.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/src/bin/pg_rewind/parsexlog.c b/src/bin/pg_rewind/parsexlog.c index 922ae3daaec..5c08d46d2a4 100644 --- a/src/bin/pg_rewind/parsexlog.c +++ b/src/bin/pg_rewind/parsexlog.c @@ -106,7 +106,11 @@ extractPageMap(const char *datadir, XLogRecPtr startpoint, int tliIndex, * If 'endpoint' didn't point exactly at a record boundary, the caller * messed up. */ - Assert(xlogreader->EndRecPtr == endpoint); + if (xlogreader->EndRecPtr != endpoint) + pg_fatal("end pointer %X/%X is not a valid end point; expected %X/%X", + (uint32) (endpoint >> 32), (uint32) (endpoint), + (uint32) (xlogreader->EndRecPtr >> 32), (uint32) + (xlogreader->EndRecPtr)); XLogReaderFree(xlogreader); if (xlogreadfd != -1) |