summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorTom Lane2016-07-28 17:26:59 +0000
committerTom Lane2016-07-28 17:26:59 +0000
commita9a998180aa417b972a4502a4ed9c69c35a7e556 (patch)
treec560ff87b8dd9a12db541124ed819fbb465e34fe /src
parent737f25cfedf05884c6ffa468b4e1024b5bcc3b81 (diff)
Improve documentation about CREATE TABLE ... LIKE.
The docs failed to explain that LIKE INCLUDING INDEXES would not preserve the names of indexes and associated constraints. Also, it wasn't mentioned that EXCLUDE constraints would be copied by this option. The latter oversight seems enough of a documentation bug to justify back-patching. In passing, do some minor copy-editing in the same area, and add an entry for LIKE under "Compatibility", since it's not exactly a faithful implementation of the standard's feature. Discussion: <20160728151154.AABE64016B@smtp.hushmail.com>
Diffstat (limited to 'src')
-rw-r--r--src/backend/parser/parse_utilcmd.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/src/backend/parser/parse_utilcmd.c b/src/backend/parser/parse_utilcmd.c
index a4b36d2963c..ea7b53f4af7 100644
--- a/src/backend/parser/parse_utilcmd.c
+++ b/src/backend/parser/parse_utilcmd.c
@@ -1015,7 +1015,9 @@ generateClonedIndexStmt(CreateStmtContext *cxt, Relation source_idx,
/*
* We don't try to preserve the name of the source index; instead, just
- * let DefineIndex() choose a reasonable name.
+ * let DefineIndex() choose a reasonable name. (If we tried to preserve
+ * the name, we'd get duplicate-relation-name failures unless the source
+ * table was in a different schema.)
*/
index->idxname = NULL;