diff options
| author | Tom Lane | 2022-07-12 15:22:52 +0000 |
|---|---|---|
| committer | Tom Lane | 2022-07-12 15:22:52 +0000 |
| commit | eea9fa9b250f4044aa35d537f234c7d44fa9db3d (patch) | |
| tree | f3103887808ab4b30e634d84cd2b740c6a246ed2 /src/tools | |
| parent | ca187d7455f174da40e26e6e0c8361821ee19559 (diff) | |
Add defenses against unexpected changes in the NodeTag enum list.
Having different build systems producing different contents of the
NodeTag enum would be catastrophic for extension ABI stability.
But that ordering depends on the order in which gen_node_support.pl
processes its input files. It seems too fragile to let the Makefiles,
MSVC build scripts, and soon meson build scripts all set this order
independently. As a klugy but serviceable solution, put a canonical
copy of the file list into gen_node_support.pl itself, and check that
against the files given on the command line.
Also, while it's fine to add and delete node tags during development,
we must not let the assigned NodeTag values change unexpectedly in
stable branches. Add a cross-check that can be enabled when a branch
is forked off (or later, but that is a time when we're unlikely to
miss doing it). It just checks that the last auto-assigned number
doesn't change, which is simplistic but will catch the most likely
sorts of mistakes.
From time to time we do need to add a node tag in a stable branch.
To support doing that without changing the branch's auto-assigned
tag numbers, invent pg_node_attr(nodetag_number(VALUE)) which can
be used to give such a node a hand-assigned tag above the last
auto-assigned one.
Discussion: https://postgr.es/m/1249010.1657574337@sss.pgh.pa.us
Diffstat (limited to 'src/tools')
| -rw-r--r-- | src/tools/RELEASE_CHANGES | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/tools/RELEASE_CHANGES b/src/tools/RELEASE_CHANGES index e8de724fcd8..73b02fa2a40 100644 --- a/src/tools/RELEASE_CHANGES +++ b/src/tools/RELEASE_CHANGES @@ -107,6 +107,10 @@ Starting a New Development Cycle placeholder), "git rm" the previous one, and update release.sgml and filelist.sgml to match. +* In the newly-made branch, change src/backend/nodes/gen_node_support.pl + to enforce ABI stability of the NodeTag list (see "ARM ABI STABILITY + CHECK HERE" therein). + * Notify the private committers email list, to ensure all committers are aware of the new branch even if they're not paying close attention to pgsql-hackers. |