diff options
| author | Noah Misch | 2021-10-24 01:36:38 +0000 |
|---|---|---|
| committer | Noah Misch | 2021-10-24 01:36:42 +0000 |
| commit | dde966efb286ddc222f17013a8cf4561a3b67a5e (patch) | |
| tree | ce01ba949b264cd854361d23ce4814bfc9768b29 /src/tools | |
| parent | affec9f6a2dec174b333b8d4c43948af9d825b46 (diff) | |
Avoid race in RelationBuildDesc() affecting CREATE INDEX CONCURRENTLY.
CIC and REINDEX CONCURRENTLY assume backends see their catalog changes
no later than each backend's next transaction start. That failed to
hold when a backend absorbed a relevant invalidation in the middle of
running RelationBuildDesc() on the CIC index. Queries that use the
resulting index can silently fail to find rows. Fix this for future
index builds by making RelationBuildDesc() loop until it finishes
without accepting a relevant invalidation. It may be necessary to
reindex to recover from past occurrences; REINDEX CONCURRENTLY suffices.
Back-patch to 9.6 (all supported versions).
Noah Misch and Andrey Borodin, reviewed (in earlier versions) by Andres
Freund.
Discussion: https://postgr.es/m/20210730022548.GA1940096@gust.leadboat.com
Diffstat (limited to 'src/tools')
| -rw-r--r-- | src/tools/pgindent/typedefs.list | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/tools/pgindent/typedefs.list b/src/tools/pgindent/typedefs.list index 6c86e9199cb..d71d1adbecd 100644 --- a/src/tools/pgindent/typedefs.list +++ b/src/tools/pgindent/typedefs.list @@ -1091,6 +1091,7 @@ ImportForeignSchemaStmt ImportForeignSchemaType ImportForeignSchema_function ImportQual +InProgressEnt IncludeWal InclusionOpaque IncrementVarSublevelsUp_context |