Pre-beta mechanical code beautification.

Run pgindent, pgperltidy, and reformat-dat-files.

The pgindent part of this is pretty small, consisting mainly of
fixing up self-inflicted formatting damage from patches that
hadn't bothered to add their new typedefs to typedefs.list.
In order to keep it from making anything worse, I manually added
a dozen or so typedefs that appeared in the existing typedefs.list
but not in the buildfarm's list.  Perhaps we should formalize that,
or better find a way to get those typedefs into the automatic list.

pgperltidy is as opinionated as always, and reformat-dat-files too.

1 files changed, 90 insertions, 53 deletions

diff --git a/src/tools/pgindent/typedefs.list b/src/tools/pgindent/typedefs.list
index 34ec87a85eb..2b83c340fb7 100644
--- a/src/tools/pgindent/typedefs.list
+++ b/src/tools/pgindent/typedefs.list
@@ -231,7 +231,6 @@ BUF_MEM
 BYTE
 BY_HANDLE_FILE_INFORMATION
 Backend
-BackendId
 BackendParameters
 BackendStartupData
 BackendState
@@ -245,7 +244,6 @@ Barrier
 BaseBackupCmd
 BaseBackupTargetHandle
 BaseBackupTargetType
-BasicArchiveData
 BeginDirectModify_function
 BeginForeignInsert_function
 BeginForeignModify_function
@@ -275,10 +273,19 @@ BlockId
 BlockIdData
 BlockInfoRecord
 BlockNumber
+BlockRefTable
+BlockRefTableBuffer
+BlockRefTableChunk
+BlockRefTableEntry
+BlockRefTableKey
+BlockRefTableReader
+BlockRefTableSerializedEntry
+BlockRefTableWriter
 BlockSampler
 BlockSamplerData
 BlockedProcData
 BlockedProcsData
+BlocktableEntry
 BloomBuildState
 BloomFilter
 BloomMetaPageData
@@ -367,6 +374,7 @@ CallStmt
 CancelRequestPacket
 Cardinality
 CaseExpr
+CaseKind
 CaseTestExpr
 CaseWhen
 Cash
@@ -483,8 +491,8 @@ CopyFromState
 CopyFromStateData
 CopyHeaderChoice
 CopyInsertMethod
-CopyMethod
 CopyLogVerbosityChoice
+CopyMethod
 CopyMultiInsertBuffer
 CopyMultiInsertInfo
 CopyOnErrorChoice
@@ -560,10 +568,14 @@ DR_intorel
 DR_printtup
 DR_sqlfunction
 DR_transientrel
+DSMRegistryCtxStruct
+DSMRegistryEntry
 DWORD
 DataDirSyncMethod
 DataDumperPtr
 DataPageDeleteStack
+DataTypesUsageChecks
+DataTypesUsageVersionCheck
 DatabaseInfo
 DateADT
 DateTimeErrorExtra
@@ -621,8 +633,6 @@ DropSubscriptionStmt
 DropTableSpaceStmt
 DropUserMappingStmt
 DropdbStmt
-DSMRegistryCtxStruct
-DSMRegistryEntry
 DumpComponents
 DumpId
 DumpOptions
@@ -758,6 +768,7 @@ FetchStmt
 FieldSelect
 FieldStore
 File
+FileBackupMethod
 FileFdwExecutionState
 FileFdwPlanState
 FileNameMap
@@ -1165,9 +1176,11 @@ ImportForeignSchemaType
 ImportForeignSchema_function
 ImportQual
 InProgressEnt
+InProgressIO
 IncludeWal
 InclusionOpaque
 IncrementVarSublevelsUp_context
+IncrementalBackupInfo
 IncrementalSort
 IncrementalSortExecutionStatus
 IncrementalSortGroupInfo
@@ -1223,7 +1236,6 @@ InjectionPointConditionType
 InjectionPointEntry
 InjectionPointSharedState
 InlineCodeBlock
-InProgressIO
 InsertStmt
 Instrumentation
 Int128AggState
@@ -1249,6 +1261,7 @@ IsForeignScanParallelSafe_function
 IsoConnInfo
 IspellDict
 Item
+ItemArray
 ItemId
 ItemIdData
 ItemPointer
@@ -1272,7 +1285,6 @@ Join
 JoinCostWorkspace
 JoinDomain
 JoinExpr
-JsonFuncExpr
 JoinHashEntry
 JoinPath
 JoinPathExtraData
@@ -1299,6 +1311,7 @@ JsonExprOp
 JsonExprState
 JsonFormat
 JsonFormatType
+JsonFuncExpr
 JsonHashEntry
 JsonIncrementalState
 JsonIsPredicate
@@ -1315,15 +1328,16 @@ JsonManifestWALRangeField
 JsonObjectAgg
 JsonObjectConstructor
 JsonOutput
-JsonParseExpr
 JsonParseContext
 JsonParseErrorType
+JsonParseExpr
 JsonParserStack
 JsonPath
 JsonPathBool
-JsonPathDatatypeStatus
+JsonPathCountVarsCallback
 JsonPathExecContext
 JsonPathExecResult
+JsonPathGetVarCallback
 JsonPathGinAddPathItemFunc
 JsonPathGinContext
 JsonPathGinExtractNodesFunc
@@ -1334,7 +1348,6 @@ JsonPathGinPathItem
 JsonPathItem
 JsonPathItemType
 JsonPathKeyword
-JsonPathMutableContext
 JsonPathParseItem
 JsonPathParseResult
 JsonPathPredicateCallback
@@ -1398,6 +1411,7 @@ LINE
 LLVMAttributeRef
 LLVMBasicBlockRef
 LLVMBuilderRef
+LLVMContextRef
 LLVMErrorRef
 LLVMIntPredicate
 LLVMJITEventListenerRef
@@ -1976,7 +1990,6 @@ ParallelHashJoinBatch
 ParallelHashJoinBatchAccessor
 ParallelHashJoinState
 ParallelIndexScanDesc
-ParallelReadyList
 ParallelSlot
 ParallelSlotArray
 ParallelSlotResultHandler
@@ -2053,6 +2066,7 @@ PathClauseUsage
 PathCostComparison
 PathHashStack
 PathKey
+PathKeyInfo
 PathKeysComparison
 PathTarget
 PatternInfo
@@ -2175,7 +2189,6 @@ PortalStrategy
 PostParseColumnRefHook
 PostgresPollingStatusType
 PostingItem
-PostmasterChildType
 PreParseColumnRefHook
 PredClass
 PredIterInfo
@@ -2199,6 +2212,7 @@ PrivTarget
 PrivateRefCountEntry
 ProcArrayStruct
 ProcLangInfo
+ProcNumber
 ProcSignalBarrierType
 ProcSignalHeader
 ProcSignalReason
@@ -2217,8 +2231,8 @@ ProjectionPath
 PromptInterruptContext
 ProtocolVersion
 PrsStorage
-PruneReason
 PruneFreezeResult
+PruneReason
 PruneState
 PruneStepResult
 PsqlScanCallbacks
@@ -2320,6 +2334,7 @@ ReadFunc
 ReadLocalXLogPageNoWaitPrivate
 ReadReplicationSlotCmd
 ReadStream
+ReadStreamBlockNumberCB
 ReassignOwnedStmt
 RecheckForeignScan_function
 RecordCacheArrayEntry
@@ -2433,6 +2448,7 @@ ResourceOwnerDesc
 ResourceReleaseCallback
 ResourceReleaseCallbackItem
 ResourceReleasePhase
+ResourceReleasePriority
 RestoreOptions
 RestorePass
 RestrictInfo
@@ -2696,8 +2712,8 @@ SpecialJoinInfo
 SpinDelayStatus
 SplitInterval
 SplitLR
-SplitPartitionContext
 SplitPageLayout
+SplitPartitionContext
 SplitPoint
 SplitTextOutputData
 SplitVar
@@ -2753,6 +2769,7 @@ SubscriptingRefState
 Subscription
 SubscriptionInfo
 SubscriptionRelState
+SummarizerReadLocalXLogPrivate
 SupportRequestCost
 SupportRequestIndexCondition
 SupportRequestOptimizeWindowClause
@@ -2761,15 +2778,16 @@ SupportRequestSelectivity
 SupportRequestSimplify
 SupportRequestWFuncMonotonic
 Syn
-SyncingTablesState
 SyncOps
 SyncRepConfigData
 SyncRepStandbyData
 SyncRequestHandler
 SyncRequestType
+SyncingTablesState
 SysFKRelationship
 SysScanDesc
 SyscacheCallbackFunction
+SysloggerStartupData
 SystemRowsSamplerData
 SystemSamplerData
 SystemTimeSamplerData
@@ -2868,6 +2886,7 @@ TestDSMRegistryStruct
 TestDecodingData
 TestDecodingTxnData
 TestSpec
+TestValueType
 TextFreq
 TextPositionState
 TheLexeme
@@ -2882,6 +2901,9 @@ TidRangeScan
 TidRangeScanState
 TidScan
 TidScanState
+TidStore
+TidStoreIter
+TidStoreIterResult
 TimeADT
 TimeLineHistoryCmd
 TimeLineHistoryEntry
@@ -2904,7 +2926,6 @@ TocEntry
 TokenAuxData
 TokenizedAuthLine
 TrackItem
-TransamVariablesData
 TransApplyAction
 TransInvalidationInfo
 TransState
@@ -2913,6 +2934,7 @@ TransactionState
 TransactionStateData
 TransactionStmt
 TransactionStmtKind
+TransamVariablesData
 TransformInfo
 TransformJsonStringValuesState
 TransitionCaptureState
@@ -2956,7 +2978,6 @@ TupleTableSlotOps
 TuplesortClusterArg
 TuplesortDatumArg
 TuplesortIndexArg
-TuplesortIndexBrinArg
 TuplesortIndexBTreeArg
 TuplesortIndexHashArg
 TuplesortInstrumentation
@@ -3009,6 +3030,7 @@ UnresolvedTup
 UnresolvedTupData
 UpdateContext
 UpdateStmt
+UploadManifestCmd
 UpperRelationKind
 UpperUniquePath
 UserAuth
@@ -3057,7 +3079,6 @@ VolatileFunctionStatus
 Vsrt
 WAIT_ORDER
 WALAvailability
-WalInsertClass
 WALInsertLock
 WALInsertLockPadded
 WALOpenSegment
@@ -3090,6 +3111,7 @@ WaitEventTimeout
 WaitPMResult
 WalCloseMethod
 WalCompression
+WalInsertClass
 WalLevel
 WalRcvData
 WalRcvExecResult
@@ -3103,6 +3125,9 @@ WalSnd
 WalSndCtlData
 WalSndSendDataCallback
 WalSndState
+WalSummarizerData
+WalSummaryFile
+WalSummaryIO
 WalSyncMethod
 WalTimeSample
 WalUsage
@@ -3127,6 +3152,7 @@ WindowStatePerAggData
 WindowStatePerFunc
 WithCheckOption
 WithClause
+WordBoundaryNext
 WordEntry
 WordEntryIN
 WordEntryPos
@@ -3217,12 +3243,15 @@ ZstdCompressorState
 _SPI_connection
 _SPI_plan
 __m128i
+__m512i
+__mmask64
 __time64_t
 _dev_t
 _ino_t
 _locale_t
 _resultmap
 _stringlist
+access_vector_t
 acquireLocksOnSubLinks_context
 add_nulling_relids_context
 adjust_appendrel_attrs_context
@@ -3241,6 +3270,7 @@ amgetbitmap_function
 amgettuple_function
 aminitparallelscan_function
 aminsert_function
+aminsertcleanup_function
 ammarkpos_function
 amoptions_function
 amparallelrescan_function
@@ -3255,13 +3285,17 @@ assign_collations_context
 auth_password_hook_typ
 autovac_table
 av_relation
+avc_cache
 avl_dbase
 avl_node
 avl_tree
 avw_dbase
 backslashResult
+backup_file_entry
+backup_file_hash
 backup_manifest_info
 backup_manifest_option
+backup_wal_range
 base_yy_extra_type
 basebackup_options
 bbsink
@@ -3295,6 +3329,8 @@ bitmapword
 bits16
 bits32
 bits8
+blockreftable_hash
+blockreftable_iterator
 bloom_filter
 boolKEY
 brin_column_state
@@ -3304,6 +3340,10 @@ cached_re_str
 canonicalize_state
 cashKEY
 catalogid_hash
+cb_cleanup_dir
+cb_options
+cb_tablespace
+cb_tablespace_mapping
 check_agg_arguments_context
 check_function_callback
 check_network_data
@@ -3370,6 +3410,7 @@ dsa_segment_header
 dsa_segment_index
 dsa_segment_map
 dshash_compare_function
+dshash_copy_function
 dshash_hash
 dshash_hash_function
 dshash_parameters
@@ -3395,6 +3436,7 @@ emit_log_hook_type
 eval_const_expressions_context
 exec_thread_arg
 execution_state
+exit_function
 explain_get_index_name_hook_type
 f_smgr
 fasthash_state
@@ -3493,6 +3535,7 @@ indexed_tlist
 inet
 inetKEY
 inet_struct
+initRowMethod
 init_function
 inline_cte_walker_context
 inline_error_callback_arg
@@ -3508,12 +3551,14 @@ int32_t
 int64
 int64KEY
 int8
+int8x16_t
 internalPQconninfoOption
 intptr_t
 intset_internal_node
 intset_leaf_node
 intset_node
 intvKEY
+io_callback_fn
 io_stat_col
 itemIdCompact
 itemIdCompactData
@@ -3524,6 +3569,8 @@ json_aelem_action
 json_manifest_error_callback
 json_manifest_per_file_callback
 json_manifest_per_wal_range_callback
+json_manifest_system_identifier_callback
+json_manifest_version_callback
 json_ofield_action
 json_scalar_action
 json_struct_action
@@ -3540,6 +3587,8 @@ list_sort_comparator
 local_relopt
 local_relopts
 local_source
+local_ts_iter
+local_ts_radix_tree
 locale_t
 locate_agg_of_level_context
 locate_var_of_level_context
@@ -3558,10 +3607,12 @@ macKEY
 macaddr
 macaddr8
 macaddr_sortsupport_state
+manifest_data
 manifest_file
 manifest_files_hash
 manifest_files_iterator
 manifest_wal_range
+manifest_writer
 map_variable_attnos_context
 max_parallel_hazard_context
 mb2wchar_with_len_converter
@@ -3608,14 +3659,16 @@ pairingheap_node
 pam_handle_t
 parallel_worker_main_type
 parse_error_callback_arg
-parser_context
 partition_method_t
 pendingPosition
+pending_label
 pgParameterStatus
 pg_atomic_flag
 pg_atomic_uint32
 pg_atomic_uint64
 pg_be_sasl_mech
+pg_case_map
+pg_category_range
 pg_checksum_context
 pg_checksum_raw_context
 pg_checksum_type
@@ -3659,10 +3712,13 @@ pg_time_usec_t
 pg_tz
 pg_tz_cache
 pg_tzenum
+pg_unicode_category
 pg_unicode_decompinfo
 pg_unicode_decomposition
 pg_unicode_norminfo
 pg_unicode_normprops
+pg_unicode_properties
+pg_unicode_range
 pg_unicode_recompinfo
 pg_utf_to_local_combined
 pg_uuid_t
@@ -3788,24 +3844,32 @@ remove_nulling_relids_context
 rendezvousHashEntry
 replace_rte_variables_callback
 replace_rte_variables_context
+report_error_fn
 ret_type
 rewind_source
 rewrite_event
 rf_context
+rfile
 rm_detail_t
-rt_node_class_test_elem
 role_auth_extra
 rolename_hash
 row_security_policy_hook_type
 rsv_callback
+rt_iter
+rt_node_class_test_elem
+rt_radix_tree
 saophash_hash
 save_buffer
 scram_state
 scram_state_enum
+security_class_t
 sem_t
+sepgsql_context_info_t
 sequence_magic
 set_join_pathlist_hook_type
 set_rel_pathlist_hook_type
+shared_ts_iter
+shared_ts_radix_tree
 shm_mq
 shm_mq_handle
 shm_mq_iovec
@@ -3871,6 +3935,7 @@ substitute_actual_srf_parameters_context
 substitute_phv_relids_context
 symbol
 tablespaceinfo
+td_entry
 teSection
 temp_tablespaces_extra
 test_re_flags
@@ -3912,6 +3977,7 @@ uid_t
 uint128
 uint16
 uint16_t
+uint16x8_t
 uint32
 uint32_t
 uint32x4_t
@@ -3951,6 +4017,7 @@ walrcv_endstreaming_fn
 walrcv_exec_fn
 walrcv_get_backend_pid_fn
 walrcv_get_conninfo_fn
+walrcv_get_dbname_from_conninfo_fn
 walrcv_get_senderinfo_fn
 walrcv_identify_system_fn
 walrcv_readtimelinehistoryfile_fn
@@ -3962,10 +4029,11 @@ wchar2mb_with_len_converter
 wchar_t
 win32_deadchild_waitinfo
 wint_t
-worker_spi_state
 worker_state
 worktable
 wrap
+ws_file_info
+ws_options
 xl_brin_createidx
 xl_brin_desummarize
 xl_brin_insert
@@ -4059,6 +4127,7 @@ xmlBuffer
 xmlBufferPtr
 xmlChar
 xmlDocPtr
+xmlError
 xmlErrorPtr
 xmlExternalEntityLoader
 xmlGenericErrorFunc
@@ -4085,35 +4154,3 @@ yyscan_t
 z_stream
 z_streamp
 zic_t
-BlockRefTable
-BlockRefTableBuffer
-BlockRefTableEntry
-BlockRefTableKey
-BlockRefTableReader
-BlockRefTableSerializedEntry
-BlockRefTableWriter
-SummarizerReadLocalXLogPrivate
-SysloggerStartupData
-WalSummarizerData
-WalSummaryFile
-WalSummaryIO
-FileBackupMethod
-IncrementalBackupInfo
-UploadManifestCmd
-backup_file_entry
-backup_wal_range
-cb_cleanup_dir
-cb_options
-cb_tablespace
-cb_tablespace_mapping
-manifest_data
-manifest_writer
-rfile
-ws_options
-ws_file_info
-PathKeyInfo
-TidStore
-TidStoreIter
-TidStoreIterResult
-BlocktableEntry
-ItemArray