diff options
| author | Peter Eisentraut | 2024-08-03 09:42:37 +0000 |
|---|---|---|
| committer | Peter Eisentraut | 2024-08-03 09:51:02 +0000 |
| commit | 66188912566b5614dff095ae86f4b1e06d58e875 (patch) | |
| tree | 3c86ba7c2b967437b29f83eb49231f43577ac023 /src/tools | |
| parent | 7926a9a80f6daf0fcc1feb1bee5c51fd001bc173 (diff) | |
Add -Wmissing-variable-declarations to the standard compilation flags
This warning flag detects global variables not declared in header
files. This is similar to what -Wmissing-prototypes does for
functions. (More correctly, it is similar to what
-Wmissing-declarations does for functions, but -Wmissing-prototypes is
a superset of that in C.)
This flag is new in GCC 14. Clang has supported it for a while.
Several recent commits have cleaned up warnings triggered by this, so
it should now be clean.
Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://www.postgresql.org/message-id/flat/e0a62134-83da-4ba4-8cdb-ceb0111c95ce@eisentraut.org
Diffstat (limited to 'src/tools')
| -rw-r--r-- | src/tools/pg_bsd_indent/Makefile | 2 | ||||
| -rw-r--r-- | src/tools/pg_bsd_indent/meson.build | 1 |
2 files changed, 3 insertions, 0 deletions
diff --git a/src/tools/pg_bsd_indent/Makefile b/src/tools/pg_bsd_indent/Makefile index d922013e40b..f721dfb0d19 100644 --- a/src/tools/pg_bsd_indent/Makefile +++ b/src/tools/pg_bsd_indent/Makefile @@ -25,6 +25,8 @@ OBJS = \ parse.o \ pr_comment.o +$(OBJS): CFLAGS += $(PERMIT_MISSING_VARIABLE_DECLARATIONS) + all: pg_bsd_indent pg_bsd_indent: $(OBJS) | submake-libpgport diff --git a/src/tools/pg_bsd_indent/meson.build b/src/tools/pg_bsd_indent/meson.build index 4387c47740e..87ed4292975 100644 --- a/src/tools/pg_bsd_indent/meson.build +++ b/src/tools/pg_bsd_indent/meson.build @@ -18,6 +18,7 @@ endif pg_bsd_indent = executable('pg_bsd_indent', pg_bsd_indent_sources, + c_args: cflags_no_missing_var_decls, dependencies: [frontend_code], include_directories: include_directories('.'), kwargs: default_bin_args + { |