diff options
| author | Tom Lane | 2021-05-11 21:52:04 +0000 |
|---|---|---|
| committer | Tom Lane | 2021-05-11 21:52:13 +0000 |
| commit | 1df3555acc78dedc3ca25eb5e83649b3da1f298f (patch) | |
| tree | 7c975d950982f7b3b16803e299af557eb0d71947 /src/tools | |
| parent | 5b2d09beaffa915edd6e74fcf030b13844d3326f (diff) | |
Get rid of the separate serial_schedule list of tests.
Having to maintain two lists of regression test scripts has proven
annoyingly error-prone. We can achieve the effect of the
serial_schedule by running the parallel_schedule with
"--max_connections=1"; so do that and remove serial_schedule.
This causes cosmetic differences in the progress output, but it
doesn't seem worth restructuring pg_regress to avoid that.
Discussion: https://postgr.es/m/899209.1620759506@sss.pgh.pa.us
Diffstat (limited to 'src/tools')
| -rw-r--r-- | src/tools/msvc/vcregress.pl | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/src/tools/msvc/vcregress.pl b/src/tools/msvc/vcregress.pl index 860899c0394..0c2d56a45be 100644 --- a/src/tools/msvc/vcregress.pl +++ b/src/tools/msvc/vcregress.pl @@ -106,6 +106,12 @@ exit 0; sub installcheck_internal { my ($schedule, @EXTRA_REGRESS_OPTS) = @_; + # for backwards compatibility, "serial" runs the tests in + # parallel_schedule one by one. + my $maxconn = $maxconn; + $maxconn = "--max_connections=1" if $schedule eq 'serial'; + $schedule = 'parallel' if $schedule eq 'serial'; + my @args = ( "../../../$Config/pg_regress/pg_regress", "--dlpath=.", @@ -132,6 +138,12 @@ sub installcheck sub check { my $schedule = shift || 'parallel'; + # for backwards compatibility, "serial" runs the tests in + # parallel_schedule one by one. + my $maxconn = $maxconn; + $maxconn = "--max_connections=1" if $schedule eq 'serial'; + $schedule = 'parallel' if $schedule eq 'serial'; + InstallTemp(); chdir "${topdir}/src/test/regress"; my @args = ( |