diff options
| author | Alvaro Herrera | 2020-05-12 20:01:52 +0000 |
|---|---|---|
| committer | Alvaro Herrera | 2020-05-12 20:07:30 +0000 |
| commit | 3e9744465dbe51822c7d76baca1f934d54ba9452 (patch) | |
| tree | 08526408599e7a83c122462413f793c0531576f4 /src/timezone | |
| parent | 6a918c3ac8a6b1d8b53cead6fcb7cbd84eee5750 (diff) | |
Add -Wimplicit-fallthrough to CFLAGS and CXXFLAGS
Use it at level 4, a bit more restrictive than the default level, and
tweak our commanding comments to FALLTHROUGH.
(However, leave zic.c alone, since it's external code; to avoid the
warnings that would appear there, change CFLAGS for that file in the
Makefile.)
Author: Julien Rouhaud <rjuju123@gmail.com>
Author: Álvaro Herrera <alvherre@alvh.no-ip.org>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/20200412081825.qyo5vwwco3fv4gdo@nol
Discussion: https://postgr.es/m/flat/E1fDenm-0000C8-IJ@gemulon.postgresql.org
Diffstat (limited to 'src/timezone')
| -rw-r--r-- | src/timezone/Makefile | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/src/timezone/Makefile b/src/timezone/Makefile index bf23ac9da97..72cc98e1dfb 100644 --- a/src/timezone/Makefile +++ b/src/timezone/Makefile @@ -55,6 +55,11 @@ ifeq (,$(ZIC)) ZIC= ./zic endif +# zic.c doesn't compile cleanly with our default +# -Wimplicit-fallthrough=4, and we don't want to touch the file since +# it's third-party code, so downgrade to 3 for that file. +zic.o: CFLAGS := $(subst -Wimplicit-fallthrough=4,-Wimplicit-fallthrough=3,$(CFLAGS)) + zic: $(ZICOBJS) | submake-libpgport $(CC) $(CFLAGS) $(ZICOBJS) $(LDFLAGS) $(LDFLAGS_EX) $(LIBS) -o $@$(X) |