diff options
| author | Robert Haas | 2016-10-27 15:19:51 +0000 |
|---|---|---|
| committer | Robert Haas | 2016-10-27 15:19:51 +0000 |
| commit | f267c1c2447bb8da6e4a6b2fcbb612762c3579a8 (patch) | |
| tree | defd77e31125ab7ca750eabf098fb319d2192102 /src/test | |
| parent | c32fe432afd4bc428acf4a237f911271746f689f (diff) | |
Fix possible pg_basebackup failure on standby with "include WAL".
If a restartpoint flushed no dirty buffers, it could fail to update
the minimum recovery point, leading to a minimum recovery point prior
to the starting REDO location. perform_base_backup() would interpret
that as meaning that no WAL files at all needed to be included in the
backup, failing an internal sanity check. To fix, have restartpoints
always update the minimum recovery point to just after the checkpoint
record itself, so that the file (or files) containing the checkpoint
record will always be included in the backup.
Code by Amit Kapila, per a design suggestion by me, with some
additional work on the code comment by me. Test case by Michael
Paquier. Report by Kyotaro Horiguchi.
Diffstat (limited to 'src/test')
| -rw-r--r-- | src/test/recovery/t/001_stream_rep.pl | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/src/test/recovery/t/001_stream_rep.pl b/src/test/recovery/t/001_stream_rep.pl index fd71095f06a..981c00ba3ec 100644 --- a/src/test/recovery/t/001_stream_rep.pl +++ b/src/test/recovery/t/001_stream_rep.pl @@ -24,6 +24,11 @@ $node_standby_1->start; # pg_basebackup works on a standby). $node_standby_1->backup($backup_name); +# Take a second backup of the standby while the master is offline. +$node_master->stop; +$node_standby_1->backup('my_backup_2'); +$node_master->start; + # Create second standby node linking to standby 1 my $node_standby_2 = get_new_node('standby_2'); $node_standby_2->init_from_backup($node_standby_1, $backup_name, |