diff options
| author | Michael Paquier | 2024-03-12 01:02:54 +0000 |
|---|---|---|
| committer | Michael Paquier | 2024-03-12 01:02:54 +0000 |
| commit | 2c8118ee5d980e11f73683fcda2329c323aa381e (patch) | |
| tree | 7527eb2a94bc9cc8821ff9afba62e03918dff351 /src/test | |
| parent | 3045324214467dd3f0bef31f6f33562b9eb93aa3 (diff) | |
Use printf's %m format instead of strerror(errno) in more places
Most callers of strerror() are removed from the backend code. The
remaining callers require special handling with a saved errno from a
previous system call. The frontend code still needs strerror() where
error states need to be handled outside of fprintf.
Note that pg_regress is not changed to use %m as the TAP output may
clobber errno, since those functions call fprintf() and friends before
evaluating the format string.
Support for %m in src/port/snprintf.c has been added in d6c55de1f99a,
hence all the stable branches currently supported include it.
Author: Dagfinn Ilmari Mannsåker
Discussion: https://postgr.es/m/87sf13jhuw.fsf@wibble.ilmari.org
Diffstat (limited to 'src/test')
| -rw-r--r-- | src/test/isolation/isolationtester.c | 2 | ||||
| -rw-r--r-- | src/test/modules/libpq_pipeline/libpq_pipeline.c | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/src/test/isolation/isolationtester.c b/src/test/isolation/isolationtester.c index 0a66235153a..ed110f740f1 100644 --- a/src/test/isolation/isolationtester.c +++ b/src/test/isolation/isolationtester.c @@ -871,7 +871,7 @@ try_complete_step(TestSpec *testspec, PermutationStep *pstep, int flags) { if (errno == EINTR) continue; - fprintf(stderr, "select failed: %s\n", strerror(errno)); + fprintf(stderr, "select failed: %m\n"); exit(1); } else if (ret == 0) /* select() timeout: check for lock wait */ diff --git a/src/test/modules/libpq_pipeline/libpq_pipeline.c b/src/test/modules/libpq_pipeline/libpq_pipeline.c index 97f8febf929..c6c7b1c3a17 100644 --- a/src/test/modules/libpq_pipeline/libpq_pipeline.c +++ b/src/test/modules/libpq_pipeline/libpq_pipeline.c @@ -492,7 +492,7 @@ test_nosync(PGconn *conn) tv.tv_usec = 0; if (select(sock + 1, &input_mask, NULL, NULL, &tv) < 0) { - fprintf(stderr, "select() failed: %s\n", strerror(errno)); + fprintf(stderr, "select() failed: %m\n"); exit_nicely(conn); } if (FD_ISSET(sock, &input_mask) && PQconsumeInput(conn) != 1) @@ -943,7 +943,7 @@ test_pipelined_insert(PGconn *conn, int n_rows) if (select(sock + 1, &input_mask, &output_mask, NULL, NULL) < 0) { - fprintf(stderr, "select() failed: %s\n", strerror(errno)); + fprintf(stderr, "select() failed: %m\n"); exit_nicely(conn); } |