summaryrefslogtreecommitdiff
path: root/src/test
diff options
context:
space:
mode:
authorDavid Rowley2023-10-03 04:09:52 +0000
committerDavid Rowley2023-10-03 04:09:52 +0000
commit2075ba9dc9af8833b1147996c15246e44a1e4fab (patch)
treebe7b822bafcf2e6fdaf7a68b56f1458e868965c8 /src/test
parent6b18b3fe2c2f375d4a5d8a69b67bc59d13d4c844 (diff)
Tidy-up some appendStringInfo*() usages
Make a few newish calls to appendStringInfo() which have no special formatting use appendStringInfoString() instead. Also, adjust usages of appendStringInfoString() which only append a string containing a single character to make use of appendStringInfoChar() instead. This makes the code marginally faster, but primarily this change is so we use the StringInfo type as it was intended to be used. Discussion: https://postgr.es/m/CAApHDvpXKQmL+r=VDNS98upqhr9yGBhv2Jw3GBFFk_wKHcB39A@mail.gmail.com
Diffstat (limited to 'src/test')
-rw-r--r--src/test/regress/pg_regress.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/test/regress/pg_regress.c b/src/test/regress/pg_regress.c
index ec67588cf58..7f704da730b 100644
--- a/src/test/regress/pg_regress.c
+++ b/src/test/regress/pg_regress.c
@@ -2339,9 +2339,9 @@ regression_main(int argc, char *argv[],
bindir ? "/" : "",
temp_instance);
if (debug)
- appendStringInfo(&cmd, " --debug");
+ appendStringInfoString(&cmd, " --debug");
if (nolocale)
- appendStringInfo(&cmd, " --no-locale");
+ appendStringInfoString(&cmd, " --no-locale");
appendStringInfo(&cmd, " > \"%s/log/initdb.log\" 2>&1", outputdir);
fflush(NULL);
if (system(cmd.data))