diff options
| author | Andres Freund | 2017-03-14 22:56:17 +0000 |
|---|---|---|
| committer | Andres Freund | 2017-03-14 22:56:17 +0000 |
| commit | 60f826c5e62446d211e15ae31710562a26afc442 (patch) | |
| tree | 380fc4c2a2a5856917f35af3535f2ff072b405ab /src/test/modules | |
| parent | eb4da3e3807d2054bb05c3eb201cb9a363682f09 (diff) | |
Improve isolation tests infrastructure.
Previously if a directory had both isolationtester and plain
regression tests, they couldn't be run in parallel, because they'd
access the same files/directories. That, so far, only affected
contrib/test_decoding.
Rather than fix that locally in contrib/test_decoding, improve
pg_regress_isolation_[install]check to use separate resources from
plain regression tests.
That requires a minor change in pg_regress, namely that the
--outputdir is created if not already existing, that seems like good
idea anyway.
Use the improved helpers even where previously not used.
Author: Tom Lane and Andres Freund
Discussion: https://postgr.es/m/20170311194831.vm5ikpczq52c2drg@alap3.anarazel.de
Diffstat (limited to 'src/test/modules')
| -rw-r--r-- | src/test/modules/snapshot_too_old/.gitignore | 2 | ||||
| -rw-r--r-- | src/test/modules/snapshot_too_old/Makefile | 6 |
2 files changed, 4 insertions, 4 deletions
diff --git a/src/test/modules/snapshot_too_old/.gitignore b/src/test/modules/snapshot_too_old/.gitignore index ef3609b7da2..5cf29ed6f85 100644 --- a/src/test/modules/snapshot_too_old/.gitignore +++ b/src/test/modules/snapshot_too_old/.gitignore @@ -1 +1 @@ -/isolation_output/ +/output_iso/ diff --git a/src/test/modules/snapshot_too_old/Makefile b/src/test/modules/snapshot_too_old/Makefile index 16339f03667..a72bfad43a0 100644 --- a/src/test/modules/snapshot_too_old/Makefile +++ b/src/test/modules/snapshot_too_old/Makefile @@ -1,6 +1,8 @@ # src/test/modules/snapshot_too_old/Makefile -EXTRA_CLEAN = ./isolation_output +# Note: because we don't tell the Makefile there are any regression tests, +# we have to clean those result files explicitly +EXTRA_CLEAN = $(pg_regress_clean_files) ISOLATIONCHECKS=sto_using_cursor sto_using_select @@ -32,10 +34,8 @@ submake-test_snapshot_too_old: $(MAKE) -C $(top_builddir)/src/test/modules/snapshot_too_old isolationcheck: | submake-isolation submake-test_snapshot_too_old temp-install - $(MKDIR_P) isolation_output $(pg_isolation_regress_check) \ --temp-config $(top_srcdir)/src/test/modules/snapshot_too_old/sto.conf \ - --outputdir=./isolation_output \ $(ISOLATIONCHECKS) isolationcheck-install-force: all | submake-isolation submake-test_snapshot_too_old temp-install |