summaryrefslogtreecommitdiff
path: root/src/port
diff options
context:
space:
mode:
authorNoah Misch2024-12-10 21:51:59 +0000
committerNoah Misch2024-12-10 21:51:59 +0000
commit8b9cbf4922756d912309567f83f81e41f1737ac7 (patch)
tree9f69b467a34faa2403811f52971eb50042b74923 /src/port
parent939b0908c87a7d82171097189b855e5d0d2dd716 (diff)
Fix elog(FATAL) before PostmasterMain() or just after fork().
Since commit 97550c0711972a9856b5db751539bbaf2f88884c, these failed with "PANIC: proc_exit() called in child process" due to uninitialized or stale MyProcPid. That was reachable if close() failed in ClosePostmasterPorts() or setlocale(category, "C") failed, both unlikely. Back-patch to v13 (all supported versions). Discussion: https://postgr.es/m/20241208034614.45.nmisch@google.com
Diffstat (limited to 'src/port')
-rw-r--r--src/port/pqsignal.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/src/port/pqsignal.c b/src/port/pqsignal.c
index 6ca2d4e20a8..bdaa9f10c8a 100644
--- a/src/port/pqsignal.c
+++ b/src/port/pqsignal.c
@@ -74,8 +74,7 @@ static volatile pqsigfunc pqsignal_handlers[PG_NSIG];
/*
* Except when called with SIG_IGN or SIG_DFL, pqsignal() sets up this function
* as the handler for all signals. This wrapper handler function checks that
- * it is called within a process that the server knows about (i.e., any process
- * that has called InitProcessGlobals(), such as a client backend), and not a
+ * it is called within a process that knew to maintain MyProcPid, and not a
* child process forked by system(3), etc. This check ensures that such child
* processes do not modify shared memory, which is often detrimental. If the
* check succeeds, the function originally provided to pqsignal() is called.