diff options
| author | Thomas Munro | 2023-11-29 03:44:19 +0000 |
|---|---|---|
| committer | Thomas Munro | 2023-11-29 04:19:25 +0000 |
| commit | 15c9ac3629936a9bb5010155d3656e913027ccb7 (patch) | |
| tree | 7af568a8acbb602d6a1f758e640a8099456df7d2 /src/port | |
| parent | a60b8a58f435c44fc54e904cb05784b49dc04d0e (diff) | |
Optimize pg_readv/pg_pwritev single vector case.
For the trivial case of iovcnt == 1, kernels are measurably slower at
dealing with the more complex arguments of preadv/pwritev than the
equivalent plain old pread/pwrite. The overheads are worth it for
iovcnt > 1, but for 1 let's just redirect to the cheaper calls. While
we could leave it to callers to worry about that, we already have to
have our own pg_ wrappers for portability reasons so it seems
reasonable to centralize this knowledge there (thanks to Heikki for this
suggestion). Try to avoid function call overheads by making them
inlinable, which might also allow the compiler to avoid the branch in
some cases. For systems that don't have preadv and pwritev (currently:
Windows and [closed] Solaris), we might as well pull the replacement
functions up into the static inline functions too.
Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi>
Discussion: https://postgr.es/m/CA+hUKGJkOiOCa+mag4BF+zHo7qo=o9CFheB8=g6uT5TUm2gkvA@mail.gmail.com
Diffstat (limited to 'src/port')
| -rw-r--r-- | src/port/meson.build | 2 | ||||
| -rw-r--r-- | src/port/preadv.c | 43 | ||||
| -rw-r--r-- | src/port/pwritev.c | 43 |
3 files changed, 0 insertions, 88 deletions
diff --git a/src/port/meson.build b/src/port/meson.build index a0d0a9583a0..576a48b48c7 100644 --- a/src/port/meson.build +++ b/src/port/meson.build @@ -66,8 +66,6 @@ replace_funcs_neg = [ ['getpeereid'], ['inet_aton'], ['mkdtemp'], - ['preadv', 'HAVE_DECL_PREADV'], - ['pwritev', 'HAVE_DECL_PWRITEV'], ['strlcat'], ['strlcpy'], ['strnlen'], diff --git a/src/port/preadv.c b/src/port/preadv.c deleted file mode 100644 index e762283e676..00000000000 --- a/src/port/preadv.c +++ /dev/null @@ -1,43 +0,0 @@ -/*------------------------------------------------------------------------- - * - * preadv.c - * Implementation of preadv(2) for platforms that lack one. - * - * Portions Copyright (c) 1996-2023, PostgreSQL Global Development Group - * - * IDENTIFICATION - * src/port/preadv.c - * - *------------------------------------------------------------------------- - */ - - -#include "c.h" - -#include <unistd.h> - -#include "port/pg_iovec.h" - -ssize_t -pg_preadv(int fd, const struct iovec *iov, int iovcnt, off_t offset) -{ - ssize_t sum = 0; - ssize_t part; - - for (int i = 0; i < iovcnt; ++i) - { - part = pg_pread(fd, iov[i].iov_base, iov[i].iov_len, offset); - if (part < 0) - { - if (i == 0) - return -1; - else - return sum; - } - sum += part; - offset += part; - if (part < iov[i].iov_len) - return sum; - } - return sum; -} diff --git a/src/port/pwritev.c b/src/port/pwritev.c deleted file mode 100644 index 519de450374..00000000000 --- a/src/port/pwritev.c +++ /dev/null @@ -1,43 +0,0 @@ -/*------------------------------------------------------------------------- - * - * pwritev.c - * Implementation of pwritev(2) for platforms that lack one. - * - * Portions Copyright (c) 1996-2023, PostgreSQL Global Development Group - * - * IDENTIFICATION - * src/port/pwritev.c - * - *------------------------------------------------------------------------- - */ - - -#include "c.h" - -#include <unistd.h> - -#include "port/pg_iovec.h" - -ssize_t -pg_pwritev(int fd, const struct iovec *iov, int iovcnt, off_t offset) -{ - ssize_t sum = 0; - ssize_t part; - - for (int i = 0; i < iovcnt; ++i) - { - part = pg_pwrite(fd, iov[i].iov_base, iov[i].iov_len, offset); - if (part < 0) - { - if (i == 0) - return -1; - else - return sum; - } - sum += part; - offset += part; - if (part < iov[i].iov_len) - return sum; - } - return sum; -} |