diff options
| author | Tom Lane | 2008-10-29 00:00:39 +0000 |
|---|---|---|
| committer | Tom Lane | 2008-10-29 00:00:39 +0000 |
| commit | 05bba3d176e0adc1a032d5c8c6ea2a7622c7dd0d (patch) | |
| tree | 59140f72d76bd4fb7fc7e8bbad6ccf57084f042a /src/pl | |
| parent | e3e3d2a789e34ff6572bdf693beb1516a228c5ff (diff) | |
Be more tense about not creating tuplestores with randomAccess = true unless
backwards scan could actually happen. In particular, pass a flag to
materialize-mode SRFs that tells them whether they need to require random
access. In passing, also suppress unneeded backward-scan overhead for a
Portal's holdStore tuplestore. Per my proposal about reducing I/O costs for
tuplestores.
Diffstat (limited to 'src/pl')
| -rw-r--r-- | src/pl/plperl/plperl.c | 5 | ||||
| -rw-r--r-- | src/pl/plpgsql/src/pl_exec.c | 6 |
2 files changed, 7 insertions, 4 deletions
diff --git a/src/pl/plperl/plperl.c b/src/pl/plperl/plperl.c index 073e41d4006..75eaf10134c 100644 --- a/src/pl/plperl/plperl.c +++ b/src/pl/plperl/plperl.c @@ -1,7 +1,7 @@ /********************************************************************** * plperl.c - perl as a procedural language for PostgreSQL * - * $PostgreSQL: pgsql/src/pl/plperl/plperl.c,v 1.140 2008/10/09 17:24:05 alvherre Exp $ + * $PostgreSQL: pgsql/src/pl/plperl/plperl.c,v 1.141 2008/10/29 00:00:39 tgl Exp $ * **********************************************************************/ @@ -1922,7 +1922,8 @@ plperl_return_next(SV *sv) current_call_data->ret_tdesc = CreateTupleDescCopy(tupdesc); current_call_data->tuple_store = - tuplestore_begin_heap(true, false, work_mem); + tuplestore_begin_heap(rsi->allowedModes & SFRM_Materialize_Random, + false, work_mem); if (prodesc->fn_retistuple) { current_call_data->attinmeta = diff --git a/src/pl/plpgsql/src/pl_exec.c b/src/pl/plpgsql/src/pl_exec.c index e2218f88315..9716b812004 100644 --- a/src/pl/plpgsql/src/pl_exec.c +++ b/src/pl/plpgsql/src/pl_exec.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/pl/plpgsql/src/pl_exec.c,v 1.221 2008/09/24 14:40:00 tgl Exp $ + * $PostgreSQL: pgsql/src/pl/plpgsql/src/pl_exec.c,v 1.222 2008/10/29 00:00:39 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -2357,7 +2357,9 @@ exec_init_tuple_store(PLpgSQL_execstate *estate) estate->tuple_store_cxt = rsi->econtext->ecxt_per_query_memory; oldcxt = MemoryContextSwitchTo(estate->tuple_store_cxt); - estate->tuple_store = tuplestore_begin_heap(true, false, work_mem); + estate->tuple_store = + tuplestore_begin_heap(rsi->allowedModes & SFRM_Materialize_Random, + false, work_mem); MemoryContextSwitchTo(oldcxt); estate->rettupdesc = rsi->expectedDesc; |