Remove support for upgrading extensions from "unpackaged" state.

Andres Freund pointed out that allowing non-superusers to run
"CREATE EXTENSION ... FROM unpackaged" has security risks, since
the unpackaged-to-1.0 scripts don't try to verify that the existing
objects they're modifying are what they expect.  Just attaching such
objects to an extension doesn't seem too dangerous, but some of them
do more than that.

We could have resolved this, perhaps, by still requiring superuser
privilege to use the FROM option.  However, it's fair to ask just what
we're accomplishing by continuing to lug the unpackaged-to-1.0 scripts
forward.  None of them have received any real testing since 9.1 days,
so they may not even work anymore (even assuming that one could still
load the previous "loose" object definitions into a v13 database).
And an installation that's trying to go from pre-9.1 to v13 or later
in one jump is going to have worse compatibility problems than whether
there's a trivial way to convert their contrib modules into extension
style.

Hence, let's just drop both those scripts and the core-code support
for "CREATE EXTENSION ... FROM".

Discussion: https://postgr.es/m/20200213233015.r6rnubcvl4egdh5r@alap3.anarazel.de

3 files changed, 2 insertions, 16 deletions

diff --git a/src/pl/plperl/GNUmakefile b/src/pl/plperl/GNUmakefile
index e4d0a0bf32e..919d46453f6 100644
--- a/src/pl/plperl/GNUmakefile
+++ b/src/pl/plperl/GNUmakefile
@@ -27,8 +27,8 @@ NAME = plperl
 
 OBJS = plperl.o SPI.o Util.o $(WIN32RES)
 
-DATA = plperl.control plperl--1.0.sql plperl--unpackaged--1.0.sql \
-       plperlu.control plperlu--1.0.sql plperlu--unpackaged--1.0.sql
+DATA = plperl.control plperl--1.0.sql \
+       plperlu.control plperlu--1.0.sql
 
 PERLCHUNKS = plc_perlboot.pl plc_trusted.pl
 
diff --git a/src/pl/plperl/plperl--unpackaged--1.0.sql b/src/pl/plperl/plperl--unpackaged--1.0.sql
deleted file mode 100644
index 5e097c443db..00000000000
--- a/src/pl/plperl/plperl--unpackaged--1.0.sql
+++ /dev/null
@@ -1,7 +0,0 @@
-/* src/pl/plperl/plperl--unpackaged--1.0.sql */
-
-ALTER EXTENSION plperl ADD LANGUAGE plperl;
--- ALTER ADD LANGUAGE doesn't pick up the support functions, so we have to.
-ALTER EXTENSION plperl ADD FUNCTION plperl_call_handler();
-ALTER EXTENSION plperl ADD FUNCTION plperl_inline_handler(internal);
-ALTER EXTENSION plperl ADD FUNCTION plperl_validator(oid);
diff --git a/src/pl/plperl/plperlu--unpackaged--1.0.sql b/src/pl/plperl/plperlu--unpackaged--1.0.sql
deleted file mode 100644
index 36de1ddf49e..00000000000
--- a/src/pl/plperl/plperlu--unpackaged--1.0.sql
+++ /dev/null
@@ -1,7 +0,0 @@
-/* src/pl/plperl/plperlu--unpackaged--1.0.sql */
-
-ALTER EXTENSION plperlu ADD LANGUAGE plperlu;
--- ALTER ADD LANGUAGE doesn't pick up the support functions, so we have to.
-ALTER EXTENSION plperlu ADD FUNCTION plperlu_call_handler();
-ALTER EXTENSION plperlu ADD FUNCTION plperlu_inline_handler(internal);
-ALTER EXTENSION plperlu ADD FUNCTION plperlu_validator(oid);