diff options
| author | Thomas Munro | 2023-07-13 23:59:07 +0000 |
|---|---|---|
| committer | Thomas Munro | 2023-07-14 00:30:13 +0000 |
| commit | d0c28601efaa8b04f11a19506f3371bba8438acc (patch) | |
| tree | 04f752fbb2ade2b6fc9f44d1c0c4d9978c98e01b /src/include | |
| parent | aea7fe33fb6a96133c47cf4b3af25a7c62f49c06 (diff) | |
Remove wal_sync_method=fsync_writethrough on Windows.
The "fsync" level already flushes drive write caches on Windows (as does
"fdatasync"), so it only confuses matters to have an apparently higher
level that isn't actually different at all.
That leaves "fsync_writethrough" only for macOS, where it actually does
something different.
Reviewed-by: Magnus Hagander <magnus@hagander.net>
Discussion: https://postgr.es/m/CA%2BhUKGJ2CG2SouPv2mca2WCTOJxYumvBARRcKPraFMB6GSEMcA%40mail.gmail.com
Diffstat (limited to 'src/include')
| -rw-r--r-- | src/include/port/win32_port.h | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/src/include/port/win32_port.h b/src/include/port/win32_port.h index 0e6d6083308..27a11c7868e 100644 --- a/src/include/port/win32_port.h +++ b/src/include/port/win32_port.h @@ -84,14 +84,6 @@ /* Windows doesn't have fsync() as such, use _commit() */ #define fsync(fd) _commit(fd) -/* - * For historical reasons, we allow setting wal_sync_method to - * fsync_writethrough on Windows, even though it's really identical to fsync - * (both code paths wind up at _commit()). - */ -#define HAVE_FSYNC_WRITETHROUGH -#define FSYNC_WRITETHROUGH_IS_FSYNC - #define USES_WINSOCK /* |